GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — [web-console] Revoke the refresh token on sign-out by Karakatiza666 · Pull Request #7781 · feldera/feldera Conversation
Contributor
Sign-out now sends the OIDC refresh token to the identity provider's revocation endpoint before it clears the local session, so the provider stops issuing access tokens for that session. Only the refresh token is revoked, because AWS Cognito's revocation endpoint rejects access tokens. If revocation fails, the client logs a warning and sign-out still completes. The authentication docs say that token revocation must be enabled for the app client, and that access tokens already issued stay valid until they expire, because pipeline-manager validates them locally. Linked IssueDescribe Manual Test PlanChecklist
Breaking Changes?Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsSign-out now sends the OIDC refresh token to the identity provider's revocation endpoint before it clears the local session, so the provider stops issuing access tokens for that session. Only the refresh token is revoked, because AWS Cognito's revocation endpoint rejects access tokens. If revocation fails, the client logs a warning and sign-out still completes. The authentication docs say that token revocation must be enabled for the app client, and that access tokens already issued stay valid until they expire, because pipeline-manager validates them locally. Co-Authored-By: Claude Opus 5.5 <[email protected]> Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
gz
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what happens if it's not enabled. is the failure graceful (logout still works)? and maybe all it should do is call it out in logs?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in that case text should be formulates as 'should' not 'must'
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Graceful. The doc is not as strict as "must"
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. drop
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Karakatiza666
force-pushed
the
web-console-revoke-refresh-token-on-sign-out
branch
from
cef5bd6 to
7cf7f49
Compare
Karakatiza666
enabled auto-merge
Karakatiza666
force-pushed
the
web-console-revoke-refresh-token-on-sign-out
branch
from
7cf7f49 to
c26f8a0
Compare
Sign-out waits for the identity provider to revoke the refresh token. The OIDC client aborts each revocation attempt after 10 s and retries an aborted attempt twice, with no option to change this, so a provider that does not answer delayed sign-out by about 30 s. The console now wraps the client's fetch so that an aborted revocation request fails with a TimeoutError, which the client does not retry. Sign-out then waits at most 10 s and completes with the refresh token unrevoked, as it does for any other revocation failure. The Sign Out button shows a pending state and ignores clicks while sign-out waits. Tests cover a provider that does not answer, a sign-out with the logout extras the console passes for Cognito, and the pending button.
Karakatiza666
force-pushed
the
web-console-revoke-refresh-token-on-sign-out
branch
from
c26f8a0 to
c8f7225
Compare
Karakatiza666
disabled auto-merge
The dummy OIDC provider publishes a revocation endpoint and forgets a refresh token when the client revokes it. A new e2e test signs in through the provider, signs out, and checks that the console revoked the refresh token and that the provider rejects it afterwards. This covers the generic OIDC path, where the console finds the revocation endpoint through discovery. The signed-in profile button gets the same accessible name as the signed-out one, so the test can open the menu. The client logs nothing when the provider answers a revocation with an error status. The code comment no longer claims that a failed revocation is logged, and the docs say that the console logs no error when revocation is disabled.
Karakatiza666
enabled auto-merge
Karakatiza666
disabled auto-merge
Uh oh!
There was an error while loading. Please reload this page.
Karakatiza666
deleted the
web-console-revoke-refresh-token-on-sign-out
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |