GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [SQL] ShareIndexes: only share indexes that read the same output port by bens-secret-alt-account · Pull Request #7784 · feldera/feldera

Conversation

@bens-secret-alt-account

@bens-secret-alt-account bens-secret-alt-account commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Linked Issue

Closes #7783

FindSharedIndexes found sibling MapIndex operators by producer operator, so for a multi-output operator (here the nested operator of two mutually recursive views) it could merge indexes over different outputs, and one view read the other's rows. This skips a sibling unless smi.input().equals(input), i.e. same operator and same port.

AI use: Claude Code (Opus 5.5) found the bug, wrote the fix and the test, and ran them.

Describe Manual Test Plan

Added SharedIndexPortTests (cross-join and equi-join over two mutually recursive views). On main at 4b6d3b4 both fail with out_b returning a's rows; with the fix they pass, and the existing ShareIndexesTests (16) still pass. Did not run the full compiler suite.

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Breaking Changes?

None.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bens-secret-alt-account
[SQL] ShareIndexes: only share indexes that read the same output port
cb82711
FindSharedIndexes looks for sibling MapIndex operators with
graph.getSuccessors(input.node()). The graph records edges per operator, not
per output port, so for a multi-output producer (such as the nested operator
of two mutually recursive views) the siblings include indexes over different
outputs. The grouping checked key and value nullability but not the port, so
ReplaceSharedIndexes built a single index from the first port and gave it to
consumers of the other port, which then silently read the wrong stream.

Skip a sibling unless it reads the same OutputPort (operator and port number).
Indexes over the same port are still shared.

The new SharedIndexPortTests joins each of two same-typed mutually recursive
views to a table (cross join and equi-join). Before the fix out_b returns a's
rows; with it both views are correct.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

Signed-off-by: bens-secret-alt-account <[email protected]>
@bens-secret-alt-account bens-secret-alt-account mentioned this pull request Nov 2, 2026
[SQL] ShareIndexes merges indexes on different outputs of a recursive view #7783
Closed
@mihaibudiu
mihaibudiu enabled auto-merge November 2, 2026 17:33
@mihaibudiu
mihaibudiu disabled auto-merge November 2, 2026 17:57
@mihaibudiu
mihaibudiu enabled auto-merge November 2, 2026 17:57
mihaibudiu
mihaibudiu approved these changes Nov 2, 2026
View reviewed changes
@mihaibudiu
mihaibudiu disabled auto-merge November 2, 2026 17:58
@mihaibudiu
mihaibudiu added this pull request to the merge queue Nov 2, 2026
Merged via the queue into feldera:main with commit 6bdf803 Nov 2, 2026
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SQL] ShareIndexes merges indexes on different outputs of a recursive view

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bens-secret-alt-account @mihaibudiu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.