GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — [SQL] ShareIndexes: only share indexes that read the same output port by bens-secret-alt-account · Pull Request #7784 · feldera/feldera Conversation
Contributor
Linked IssueCloses #7783
AI use: Claude Code (Opus 5.5) found the bug, wrote the fix and the test, and ran them. Describe Manual Test PlanAdded Checklist
Breaking Changes?None.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsFindSharedIndexes looks for sibling MapIndex operators with graph.getSuccessors(input.node()). The graph records edges per operator, not per output port, so for a multi-output producer (such as the nested operator of two mutually recursive views) the siblings include indexes over different outputs. The grouping checked key and value nullability but not the port, so ReplaceSharedIndexes built a single index from the first port and gave it to consumers of the other port, which then silently read the wrong stream. Skip a sibling unless it reads the same OutputPort (operator and port number). Indexes over the same port are still shared. The new SharedIndexPortTests joins each of two same-typed mutually recursive views to a table (cross join and equi-join). Before the fix out_b returns a's rows; with it both views are correct. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: bens-secret-alt-account <[email protected]>
mihaibudiu
enabled auto-merge
mihaibudiu
disabled auto-merge
mihaibudiu
enabled auto-merge
mihaibudiu
approved these changes
mihaibudiu
disabled auto-merge
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. [SQL] ShareIndexes merges indexes on different outputs of a recursive viewUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |