GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [SQL] Emit the type for each expression in the IR JSON by mihaibudiu · Pull Request #7805 · feldera/feldera

Conversation

@mihaibudiu

@mihaibudiu mihaibudiu commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #7803

  • Unit tests added/updated- [ ] Integration tests added/updated

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gz
gz approved these changes Nov 3, 2026
View reviewed changes
mythical-fred-oss[bot]
mythical-fred-oss Bot reviewed Nov 3, 2026
View reviewed changes
Comment thread ...bsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/Gen2JsonTests.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
mythical-fred-oss[bot]
mythical-fred-oss Bot reviewed Nov 3, 2026
View reviewed changes
Comment thread ...bsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/Gen2JsonTests.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mythical-fred-oss

mythical-fred-oss Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

What I ran (./build.sh, then mvn test -pl SQL-compiler):

Test Result
Gen2JsonTests 14/14 pass
OtherTests#serializationTest (JSON round-trip) pass
MetadataTests 87/87 pass
Gen2JsonTests with ir.aggregate added to isExpression pass

Correctness: I checked the writer and decoder. pop runs before postorder closes the object, so type stays inside the node. No ToJsonInnerVisitor postorder writes type any more, so no key appears twice. Every expression that visits its own type does it under the type property, which the hasType tracking relies on. The decoder skips types that are references or already cached. I found no bugs.

Gates: no gate fails. The change is covered by a unit test, I see nothing flaky, and the JSON IR is not a documented user surface.

missing (medium): test coverage is partial; see the inline comments.

  • The aggregate package is not checked.
  • About 11 of the expression classes named in [SQL] IR JSON representation does not include types for some expressions #7803 are never produced by the test programs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mihaibudiu
[SQL] Emit the type for each expression in the IR JSON
f3bc9f8 
Fixes #7803

Signed-off-by: Mihai Budiu <[email protected]>
@mihaibudiu
mihaibudiu force-pushed the issue7803 branch from dd24776 to f3bc9f8 Compare November 3, 2026 19:57
@mihaibudiu
mihaibudiu added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit c01891b Nov 4, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.
@mihaibudiu
mihaibudiu deleted the issue7803 branch November 4, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mythical-fred-oss mythical-fred-oss[bot] mythical-fred-oss[bot] left review comments
@gz gz gz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SQL] IR JSON representation does not include types for some expressions

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mihaibudiu @gz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.