GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [ci] Give the iceberg-rest catalog one sqlite connection. by swanandx · Pull Request #7834 · feldera/feldera

Conversation

@swanandx

@swanandx swanandx commented Nov 4, 2026

Copy link
Copy Markdown
Member

Linked Issue

Closes #7440. The test catalog keeps its tables in sqlite and uses two connections. Sometimes one connection finds the database locked by the other, and an iceberg follow test fails with HTTP 500.

before: 2 connections -> "database is locked" -> HTTP 500 -> test fails
after:  1 connection  -> requests wait their turn -> no lock errors

Describe Manual Test Plan

I ran the CI catalog image locally and sent it many requests at the same time. With two connections, 4 of 4 runs got the HTTP 500. With one connection, 8 of 8 runs had no errors, and the iceberg follow tests passed 60 of 60 times.

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Breaking Changes?

Mark if you think the answer is yes for any of these components:

  • OpenAPI / REST HTTP API / feldera-types / manager (What is a breaking change?)
  • Feldera SQL (Syntax, Semantics)
  • feldera-sqllib (incl. dependencies fxp, etc.) (What is a breaking change?)
  • Python SDK (What is a breaking change?)
  • fda (CLI arguments)
  • Adapters (including configuration)
  • Storage Format / Checkpoints
  • Others (specify)

Describe Incompatible Changes

None.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@swanandx
[ci] Give the iceberg-rest catalog one sqlite connection.
173c69a 
The catalog uses two sqlite connections by default. Sometimes one
finds the database locked by the other (SQLITE_BUSY), and the
follow tests get an HTTP 500.

Signed-off-by: Swanand Mulay <[email protected]>
@swanandx swanandx mentioned this pull request Nov 4, 2026
Adapter/Runtime Integration Tests: network-timeout flakiness to GCS/S3/Iceberg-REST/Unity (not PR #7393's fault) #7440
Closed
@mythical-fred-oss

mythical-fred-oss Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

LGTM. CI-only change. CATALOG_CLIENTS becomes the catalog property clients, which sets the JdbcClientPool size (the default is 2), so one connection does serialize sqlite access as the comment says. pre-commit run passes on the workflow file. The PR adds no test, which is fine for CI config, and the manual run (60/60 follow-test passes) is the right evidence for a flake fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@swanandx
swanandx requested a review from gz November 4, 2026 12:38
bestouff
bestouff approved these changes Nov 4, 2026
View reviewed changes
@swanandx
swanandx added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit ff09605 Nov 4, 2026
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@swanandx
swanandx deleted the issue7440 branch November 4, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bestouff bestouff bestouff approved these changes
@gz gz Awaiting requested review from gz

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adapter/Runtime Integration Tests: network-timeout flakiness to GCS/S3/Iceberg-REST/Unity (not PR #7393's fault)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@swanandx @bestouff
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.