GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [python] Remove redundant `wait_for_idle` calls from `test_uda`. by blp · Pull Request #7845 · feldera/feldera

Conversation

@blp

@blp blp commented Nov 4, 2026

Copy link
Copy Markdown
Member

input_json waits for its completion token before it returns, so the ad-hoc query that follows already sees the input. The other three input_json calls in test_uda already query without wait_for_idle.

The flake in #7082 did not come from wait_for_idle. A completion token could complete one step early, before update_snapshot() ran, so the ad-hoc query read the old, empty snapshot. a489b4b fixed that on 2026-10-09; the failure was on 2026-09-08.

Closes #7082.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@blp
[python] Remove redundant wait_for_idle calls from test_uda.
dd51b17 
`input_json` waits for its completion token before it returns, so the
ad-hoc query that follows already sees the input.  The other three
`input_json` calls in this test already query without `wait_for_idle`.

The flake in #7082 came from a completion token that completed one step
early, fixed in a489b4b, not from `wait_for_idle`.

Signed-off-by: Ben Pfaff <[email protected]>
@blp blp added QA Testing and quality assurance python Pull requests that update python code labels Nov 4, 2026
@blp blp self-assigned this Nov 4, 2026
mihaibudiu
mihaibudiu approved these changes Nov 4, 2026
View reviewed changes
@mythical-fred-oss

mythical-fred-oss Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

LGTM.

  • Ran: pre-commit run --files python/tests/runtime/test_uda.py; ruff and ruff-format passed. I did not run the runtime test itself, because it needs a running pipeline-manager.
  • Checked the claim: in crates/connectors/src/controller.rs, the step loop calls update_snapshot() before it updates the processed-record count. Completion tokens wait on that count, so input_json(wait=True) now returns only after the ad-hoc snapshot has the input. That makes the removed wait_for_idle() calls redundant, and the test's other input_json → query sequences already work without them.
  • Gates: this changes only a test, so it adds no behaviour, docs or dependency concerns. The commit message explains the why.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blp
blp enabled auto-merge November 4, 2026 22:08
@blp
blp disabled auto-merge November 5, 2026 18:37
@blp
blp added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit c91a878 Nov 5, 2026
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@blp
blp deleted the test-uda-drop-wait-for-idle branch November 5, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@blp blp

Labels

python Pull requests that update python code QA Testing and quality assurance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wait_for_idle can return before newly-pushed input reaches the pipeline (test_uda flake)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@blp @mihaibudiu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.