GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Docs: brand scrollbars by tristencross · Pull Request #7855 · feldera/feldera Conversation
|
| } | ||
|
|
||
| ::-webkit-scrollbar-thumb:hover { | ||
| background: var(--color-clay); |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
bug (medium): --color-clay isn't defined anywhere (the :root brand tokens only have paper/card/sink/shell/stone/ink/violet/onyx/moss/change*). var() with no fallback makes this invalid at computed-value time, so background falls back to transparent: in Safari the thumb disappears on hover instead of turning Clay. Add the token to :root, or use an existing one.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| html, | ||
| .theme-doc-sidebar-menu, | ||
| .table-of-contents, | ||
| .markdown table, | ||
| .markdown .table-scroll-container { | ||
| scrollbar-width: thin; | ||
| scrollbar-color: var(--color-stone) transparent; | ||
| } |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
pitfall (medium): scrollbar-color is an inherited property, and since Chrome/Edge 121 any element whose computed scrollbar-color/scrollbar-width isn't auto ignores ::-webkit-scrollbar*. Setting it on html passes it down to every element, .theme-code-block pre included. So in current Chrome/Edge, the 8px square thumb, the Clay hover and the faint code-block thumb (L438-445) never apply. Code blocks get a Stone thumb on the dark background instead. Only Safari uses the webkit block. To fix, give the code blocks their own standard rule (.theme-code-block pre { scrollbar-color: rgb(250 249 246 / 0.2) transparent; }), and accept that Chromium shows no hover or square-thumb styling, or stop setting the standard props on html in Chromium.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Scope: CSS only. Brand scrollbars in What I ran:
Manual QA to do before merge: in each of the three engines, check a long page, the sidebar, the TOC, a wide table and a wide code block, and hover the thumb. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
At least 1 approving review is required to merge this pull request.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.