GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Docs: brand scrollbars by tristencross · Pull Request #7855 · feldera/feldera

Conversation

@tristencross

@tristencross tristencross commented Nov 5, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Branded the scrollbars for mobile, so a thin Stone tile turns Clay on hover.

Screen.Recording.2026-11-05.at.7.59.11.AM.mov

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
tristencross added 2 commits November 5, 2026 07:54
@tristencross
docs: brand scrollbars, a thin Stone bar on Paper, Clay on hover, lig…
b185350
…ht on dark code blocks
@tristencross
docs: square scrollbar thumb, as the brand's buttons and cards
36b2225
@tristencross
tristencross requested review from Karakatiza666 and lalithsuresh November 5, 2026 15:57
mythical-fred-oss[bot]
mythical-fred-oss Bot reviewed Nov 5, 2026
View reviewed changes
Comment thread docs.feldera.com/src/css/custom.css
}

::-webkit-scrollbar-thumb:hover {
background: var(--color-clay);

@mythical-fred-oss mythical-fred-oss Bot Nov 5, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug (medium): --color-clay isn't defined anywhere (the :root brand tokens only have paper/card/sink/shell/stone/ink/violet/onyx/moss/change*). var() with no fallback makes this invalid at computed-value time, so background falls back to transparent: in Safari the thumb disappears on hover instead of turning Clay. Add the token to :root, or use an existing one.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mythical-fred-oss[bot]
mythical-fred-oss Bot reviewed Nov 5, 2026
View reviewed changes
Comment thread docs.feldera.com/src/css/custom.css
Comment on lines +403 to +410
html,
.theme-doc-sidebar-menu,
.table-of-contents,
.markdown table,
.markdown .table-scroll-container {
scrollbar-width: thin;
scrollbar-color: var(--color-stone) transparent;
}

@mythical-fred-oss mythical-fred-oss Bot Nov 5, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pitfall (medium): scrollbar-color is an inherited property, and since Chrome/Edge 121 any element whose computed scrollbar-color/scrollbar-width isn't auto ignores ::-webkit-scrollbar*. Setting it on html passes it down to every element, .theme-code-block pre included. So in current Chrome/Edge, the 8px square thumb, the Clay hover and the faint code-block thumb (L438-445) never apply. Code blocks get a Stone thumb on the dark background instead. Only Safari uses the webkit block. To fix, give the code blocks their own standard rule (.theme-code-block pre { scrollbar-color: rgb(250 249 246 / 0.2) transparent; }), and accept that Chromium shows no hover or square-thumb styling, or stop setting the standard props on html in Chromium.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mythical-fred-oss

mythical-fred-oss Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Scope: CSS only. Brand scrollbars in docs.feldera.com/src/css/custom.css. No runtime, API or test surface.

What I ran: pre-commit run --files docs.feldera.com/src/css/custom.css passed. I did not build or open the docs site in a browser, so I checked the rendering rules by reading the CSS.

Severity Item
bug (medium) --color-clay is undefined, so the thumb vanishes on hover (inline)
pitfall (medium) scrollbar-color on html is inherited, which turns off all ::-webkit-scrollbar rules in Chrome/Edge 121+. The code-block override never applies there (inline)
missing (low→medium) The PR description is empty, with no manual-testing note. Please say which browsers you checked (Chrome, Safari, Firefox) and include a screenshot of a scrolling code block

Manual QA to do before merge: in each of the three engines, check a long page, the sidebar, the TOC, a wide table and a wide code block, and hover the thumb.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mythical-fred-oss mythical-fred-oss[bot] mythical-fred-oss[bot] left review comments
@lalithsuresh lalithsuresh Awaiting requested review from lalithsuresh
@Karakatiza666 Karakatiza666 Awaiting requested review from Karakatiza666

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@tristencross
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.