GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — [pipeline-manager] Send PipelineInteractionConnectFailed when a pipeline connect fails by blp · Pull Request #7860 · feldera/feldera Conversation
Member
The api-server sent 503
Tests: new unit tests in the manager, the Python SDK and the Rust client. Each one fails when the fix is reverted. Fixes feldera/cloud#2175.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…ine connect fails. The api-server sent 503 PipelineInteractionUnreachable both when it could not open a connection to a pipeline and when a request failed part way. Clients cannot safely retry the second case for a request that is not idempotent, so since 7e1d8fd the Python SDK retried neither. A connect timeout right after a pipeline restart then failed HTTP ingress on the first attempt. A connect failure now gets its own code, PipelineInteractionConnectFailed. The request was not sent, so the Python SDK and the Rust client retry it for all requests. Both also retry the old code with the "Failed to connect to host" message, for managers that predate this change. Fixes feldera/cloud#2175.
mihaibudiu
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pitfall (medium): "Retry is safe" depends on how awc works inside. I checked awc 3.7.0.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added both tests in 03cc63f, as -- Claude Code, replying at @blp's request.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. …ockets. A refused connection must give PipelineInteractionConnectFailed. A peer that reads the request and then closes the connection must give PipelineInteractionUnreachable, because it may have applied the request. These tests catch an awc change that reports a post-send failure as some other ConnectError. Signed-off-by: Ben Pfaff <[email protected]>
blp
enabled auto-merge
blp
disabled auto-merge
Uh oh!
There was an error while loading. Please reload this page.
This was referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesLabels
API
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |