GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: docs improvements by lalithsuresh · Pull Request #7889 · feldera/feldera

Conversation

@lalithsuresh

@lalithsuresh lalithsuresh commented Nov 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Fix API docs styling:

Before:
image
image

After:
image
image

  • Add some more guides on use cases
  • Add missing llms.txt

Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • Documentation updated
  • Changelog updated

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mythical-fred-oss[bot]
mythical-fred-oss Bot reviewed Nov 7, 2026
View reviewed changes
Comment thread docs.feldera.com/src/css/custom.css
--openapi-input-background: var(--color-card);
--openapi-input-border: var(--color-ink);
--ifm-pre-color: var(--color-ink);
--ifm-menu-color-background-active: var(--color-ink);

@mythical-fred-oss mythical-fred-oss Bot Nov 7, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pitfall (medium): In docusaurus-theme-openapi 0.7.x, Curl/styles.module.css uses this variable for .buttonGroup button:hover too, not just .selected. An unselected language tab (cURL/Python/Node…) keeps color: var(--ifm-menu-color) (surface-600, about 48% L) when hovered, so on an ink background the label is only about 2.6:1 contrast and hard to read. One possible fix is to also set the hover text colour:

.api-wrapper .col--5 [class*="buttonGroup"] button:hover { color: var(--ifm-menu-color-active); }

Or use a lighter hover background than the selected state.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mythical-fred-oss

mythical-fred-oss Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Review (CSS only, docs site)

Check Result
pre-commit run --files custom.css passed
Variables used (--color-sink/card/ink/stone/surface-400) all defined in :root
Dark mode N/A (disableSwitch: true, light only)
Scope Limited to .api-wrapper .col--5. The Curl/Response <pre> and the form inputs in theme-openapi 0.7.7 read --openapi-card-background-color and --ifm-pre-color, so they now show dark text on a warm grey background, as intended
Gates Visual-only change with before/after screenshots, so no tests needed. A one-line commit message is fine for a change this small

One medium inline note about hover contrast on the language tabs. Otherwise LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lalithsuresh
docs: fix API section colors
da641b9 
Signed-off-by: Lalith Suresh <[email protected]>
@lalithsuresh
lalithsuresh force-pushed the api-colors branch from e93b931 to da641b9 Compare November 7, 2026 15:04
@lalithsuresh lalithsuresh changed the title docs: fix API section colors docs: docs improvements Nov 7, 2026
gz
gz approved these changes Nov 7, 2026
View reviewed changes
@lalithsuresh
lalithsuresh added this pull request to the merge queue Nov 7, 2026
Merged via the queue into main with commit 5e5d192 Nov 7, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.
@lalithsuresh
lalithsuresh deleted the api-colors branch November 7, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mythical-fred-oss mythical-fred-oss[bot] mythical-fred-oss[bot] left review comments
@gz gz gz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lalithsuresh @gz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.