GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||
GeezerVison is showing github.com — Keep only the newest checkpoint on storage by blp · Pull Request #7905 · feldera/feldera Conversation
Member
A pipeline kept its two newest checkpoints on storage. The older one is not needed on a single host: the newest checkpoint lists every batch that the pipeline used when it wrote it, so the older checkpoint's other files are unused. With a long delay between checkpoints, the older checkpoint could use as much storage again as the pipeline's state. Commits
Testing
Also ran the dbsp checkpoint and GC tests, the connector-suite checkpoint, suspend, and restore tests, and the Kafka FT and Postgres CDC tests against local Redpanda and Postgres.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
mihaibudiu
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this using the timestamp encoded in the uuid?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No. "Older" means written earlier. The checkpointer keeps If -- Claude Code, replying at @blp's request.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
blp
enabled auto-merge
blp
force-pushed
the
single-checkpoint
branch
from
79363f2 to
fac88f8
Compare
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
blp
disabled auto-merge
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Uh oh!
There was an error while loading. Please reload this page.
blp
force-pushed
the
single-checkpoint
branch
from
fac88f8 to
3d13bb7
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Uh oh!
There was an error while loading. Please reload this page. A pipeline kept its two newest checkpoints. The older one is not needed: the newest checkpoint lists every batch that the pipeline used when it wrote it, so the older checkpoint's other files are unused. Keeping it could use as much storage again as the pipeline's state. `gc_checkpoint` now takes the number of checkpoints to keep. A single host keeps 1. A host of a multihost pipeline still keeps 2, because a restart resumes from the newest checkpoint that every host has. Fixes #7035. Signed-off-by: Ben Pfaff <[email protected]> … has the newest. A host of a multihost pipeline keeps its previous checkpoint, because a restart resumes from the newest checkpoint that every host has. After a checkpoint succeeds on every host, the coordinator can now say so with `POST /coordination/checkpoint/complete`, which names this host's copy of that checkpoint. The host then deletes its older checkpoints, with the new `gc_checkpoints_before`. The request names the checkpoint, instead of only saying "delete the older one", so that a late request cannot delete a checkpoint that another host still lacks. Signed-off-by: Ben Pfaff <[email protected]>
blp
force-pushed
the
single-checkpoint
branch
from
3d13bb7 to
63b58ef
Compare
blp
enabled auto-merge
blp
disabled auto-merge
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. [dbsp] Keeping two checkpoints around is wastefulUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |