GeezerVison

breaking-change (medium): GET /v0/pipelines/{name}/circuit_profile and fda circuit-profile are removed outright. They were never marked deprecated: the old openapi had no deprecated flag, and #5217 asked for "deprecate and remove". The breaking-changes policy asks for deprecated in utoipa/openapi plus Deprecation/Sunset headers for at least 2 minor releases before removal (at least 1 for the CLI command). Scripts that call this endpoint will start getting 404s on upgrade. Unless the team has agreed to skip that window for this endpoint, please split this into a deprecate PR now and a removal PR later. Otherwise, mention that decision here.

missing test (medium): The test at ~L1523 covers deserializing a v4 bundle with dot bytes into this slot. Nothing covers what push_to_zip then does with a stored Ok(bytes): the zip should not contain circuit_profile.zip and the summary should not report a failure. I ran this test locally and it passes:

#[tokio::test]
async fn push_to_zip_drops_stored_legacy_dot_profile() {
    let mut bundle_data = SupportBundleData::test_data();
    bundle_data.legacy_dot_profile = Ok(b"PK\x03\x04 old dot zip".to_vec());
    let mut names = Vec::new();
    let summary = bundle_data
        .push_to_zip(&mut |f, _, _| { names.push(f.to_string()); Ok(()) },
                     &SupportBundleParameters::default())
        .await
        .unwrap();
    assert!(!names.iter().any(|n| n == "circuit_profile.zip"), "{names:?}");
    assert!(!summary.failed.iter().any(|f| format!("{f:?}").contains("circuit_profile.zip")));
}