GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: Fix the Confluent JDBC key example and list the Iceberg path-style option by gz · Pull Request #7919 · feldera/feldera

Conversation

@gz

@gz gz commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

The Confluent JDBC example set key_fields in the Avro format config, which the pipeline rejects as an unknown field; the key comes from the index of the connector. The Iceberg source page now lists s3.path-style-access, which S3-compatible stores such as MinIO need.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gz
docs: Fix the Confluent JDBC key example and list the Iceberg path-st…
df79e87 
…yle option.

The Avro format has no key_fields option, so a pipeline with the documented example fails to start; the key comes from the index of the connector. iceberg_input reads from S3-compatible stores such as MinIO only with s3.path-style-access.

Signed-off-by: Gerd Zellweger <[email protected]>
@mythical-fred-oss

mythical-fred-oss Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

LGTM. Docs-only change. I checked it against the code:

  • AvroEncoderConfig uses deny_unknown_fields and has no key_fields field, so the old example was rejected. With confluent_jdbc, the key schema comes from the connector's index and falls back to the full value schema when there is no index (crates/connectors/src/format/avro/output.rs ~L529). The new text describes that correctly.
  • The Iceberg input integration test (crates/connectors/src/test/iceberg.rs ~L918) already passes s3.path-style-access.
  • pre-commit run on both files passed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mihaibudiu
mihaibudiu approved these changes Nov 10, 2026
View reviewed changes
Comment thread docs.feldera.com/docs/connectors/sinks/confluent-jdbc.md
key in the external database table. When not specified, the encoder assumes that all columns in the
view are part of the primary key.

Set the `index` property of the connector to an index over the view columns that form the primary

@mihaibudiu mihaibudiu Nov 10, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is cool

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gz @mihaibudiu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.