GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — chore(deps): upgrade dependencies after dropping Python 3.9. by lahirumaramba · Pull Request #1003 · firebase/firebase-admin-python

Conversation

lahirumaramba commented Nov 9, 2026

Copy link

Copy Markdown

Member

Now that Python 3.9 and PyPy 3.9 support have been removed (#1001), several runtime and development dependencies were still held back on older floors or legacy PyPy upper-bound caps. Leaving old floors in place exposes default installs to resolved upstream security advisories in cryptography, pyjwt, pylint, and pytest, and leaves setup.py out of sync with requirements.txt.

This PR upgrades our runtime and test dependencies to their latest stable Python 3.10+ releases across both setup.py and requirements.txt, and replaces the legacy cryptography < 44.0.0 PyPy cap with cryptography >= 50.0.2.

Technical Details

Synced install_requires in setup.py with requirements.txt: google-cloud-firestore >= 2.34.1, cryptography >= 50.0.2, pyjwt[crypto] >= 2.15.1, google-api-core[grpc] >= 2.44.0, < 3.0.0dev, google-cloud-storage >= 3.17.1, and cachecontrol >= 0.14.4.
Upgraded dev and test tooling in requirements.txt: pylint == 4.1.3, astroid == 4.3.4, pytest >= 9.2.0, pytest-cov >= 7.1.0, pytest-asyncio >= 1.4.1, and pytest-mock >= 3.17.0.
Set asyncio_default_fixture_loop_scope = function in setup.cfg for pytest-asyncio 1.x compatibility, and fixed a self-comparison assertion in integration/test_tenant_mgt.py caught by pylint 4.1.3.

Testing: Verified ./lint.sh all, pytest, and built wheel metadata locally.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gemini-code-assist[bot] reacted with eyes emoji

All reactions

👀 1 reaction


          chore(deps): upgrade dependencies after dropping Python 3.9.

87be180

Upgrade runtime and development dependencies to their latest stable releases now that Python 3.9 and PyPy 3.9 are dropped, and replace the legacy PyPy cryptography upper-bound cap with cryptography >= 50.0.2. Also configure asyncio_default_fixture_loop_scope for pytest-asyncio 1.x and fix a redundant self-comparison caught by pylint 4.x in test_tenant_mgt.py.

lahirumaramba requested a review from a team

November 9, 2026 21:27

gemini-code-assist Bot reviewed

Nov 9, 2026

View reviewed changes

gemini-code-assist Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a test assertion bug in integration/test_tenant_mgt.py by avoiding variable shadowing, configures the default asyncio fixture loop scope in setup.cfg, and updates various dependencies in requirements.txt and setup.py. However, the review comments correctly point out that several of the specified dependency versions (including astroid, pylint, pytest, google-cloud-firestore, google-cloud-storage, pyjwt, and cryptography) do not exist on PyPI, which will break installation and CI/CD pipelines.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

requirements.txt

Comment on lines +1 to +4

		astroid == 4.3.4
		pylint == 4.1.3
		pytest >= 9.2.0
		pytest-cov >= 7.1.0

gemini-code-assist Bot Nov 9, 2026

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specified versions for astroid (4.3.4), pylint (4.1.3), pytest (9.2.0), and pytest-cov (7.1.0) do not exist on PyPI. The current stable major versions are astroid 3.x, pylint 3.x, pytest 8.x, and pytest-cov 6.x. Using non-existent versions will cause installation and CI/CD failures.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lahirumaramba reacted with thumbs down emoji

All reactions

👎 1 reaction

lahirumaramba Nov 9, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist The latest astroid v4.3.4 (released on Oct 8, exists)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

gemini-code-assist Bot Nov 9, 2026

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the confusion. You are correct that astroid 3.x and 4.x versions exist. My previous assessment was based on a stale index. Thank you for the clarification.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

requirements.txt

Comment on lines +6 to +7

		pytest-asyncio >= 1.4.1
		pytest-mock >= 3.17.0

gemini-code-assist Bot Nov 9, 2026

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specified versions for pytest-asyncio (1.4.1) and pytest-mock (3.17.0) do not exist on PyPI. The current stable versions are pytest-asyncio 0.25.x and pytest-mock 3.14.x. Using non-existent versions will cause installation and CI/CD failures.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lahirumaramba reacted with thumbs down emoji

All reactions

👎 1 reaction

Comment thread

requirements.txt

Comment on lines +11 to +15

		google-api-core[grpc] >= 2.44.0, < 3.0.0dev; platform.python_implementation != 'PyPy'
		google-cloud-firestore >= 2.34.1; platform.python_implementation != 'PyPy'
		google-cloud-storage >= 3.17.1
		pyjwt[crypto] >= 2.15.1
		cryptography >= 50.0.2

gemini-code-assist Bot Nov 9, 2026

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several of the specified runtime dependency versions do not exist on PyPI:\n- google-cloud-firestore>=2.34.1 (current stable is 2.19.x)\n- google-cloud-storage>=3.17.1 (current stable is 2.19.x)\n- pyjwt[crypto]>=2.15.1 (current stable is 2.10.x)\n- cryptography>=50.0.2 (current stable is 44.x)\n\nUsing non-existent versions will cause installation failures.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lahirumaramba reacted with thumbs down emoji

All reactions

👎 1 reaction

Comment thread

setup.py

Comment on lines +41 to +45

		'google-api-core[grpc] >= 2.44.0, < 3.0.0dev; platform.python_implementation != "PyPy"',
		'google-cloud-firestore>=2.34.1; platform.python_implementation != "PyPy"',
		'google-cloud-storage>=3.17.1',
		'pyjwt[crypto] >= 2.15.1',
		'cryptography >= 50.0.2',

gemini-code-assist Bot Nov 9, 2026

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several of the specified runtime dependency versions in install_requires do not exist on PyPI:\n- google-api-core[grpc] >= 2.44.0 (current stable is 2.24.x)\n- google-cloud-firestore >= 2.34.1 (current stable is 2.19.x)\n- google-cloud-storage >= 3.17.1 (current stable is 2.19.x)\n- pyjwt[crypto] >= 2.15.1 (current stable is 2.10.x)\n- cryptography >= 50.0.2 (current stable is 44.x)\n\nUsing non-existent versions will cause installation failures for downstream users of this library.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lahirumaramba reacted with thumbs down emoji

All reactions

👎 1 reaction

lahirumaramba assigned yvonnep165

Nov 10, 2026

lahirumaramba requested a review from yvonnep165

November 10, 2026 15:45

yvonnep165 approved these changes

Nov 10, 2026

View reviewed changes

yvonnep165 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

lahirumaramba merged commit b7a7c41 into main

Nov 10, 2026

23 checks passed

Uh oh!

There was an error while loading. Please reload this page.

lahirumaramba mentioned this pull request

Nov 11, 2026

[chore] Release 7.8.0 #1005

Merged

Reviewers

yvonnep165

yvonnep165 approved these changes

+1 more reviewer

gemini-code-assist[bot]

gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

yvonnep165

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.