GeezerVison is showing github.com — Update to React 16.2.0 for Fragments, Replace Unnecessary <div /> on HOC. by notadamking · Pull Request #292 · fullstackreact/google-maps-react
Conversation
notadamking
commented
Dec 4, 2018
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Problem
The <div /> surrounding the <WrappedComponent /> causes styles to render incorrectly on the wrapped component.
Fix
Replace the <div /> with <React.Fragment /> to prevent stylistic changes.
I also removed unused lines of code from the GoogleApiComponent, and then ran make build to update the dist folder.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
> [email protected] prepublish /Users/adam/Desktop/Projects/google-maps-react
> ./scripts/prepublish.sh
=> Transpiling...
src/GoogleApiComponent.js -> dist/GoogleApiComponent.js
src/components/Circle.js -> dist/components/Circle.js
src/components/HeatMap.js -> dist/components/HeatMap.js
src/components/InfoWindow.js -> dist/components/InfoWindow.js
src/components/Marker.js -> dist/components/Marker.js
src/components/Polygon.js -> dist/components/Polygon.js
src/components/Polyline.js -> dist/components/Polyline.js
src/index.js -> dist/index.js
src/lib/GoogleApi.js -> dist/lib/GoogleApi.js
src/lib/ScriptCache.js -> dist/lib/ScriptCache.js
src/lib/String.js -> dist/lib/String.js
src/lib/arePathsEqual.js -> dist/lib/arePathsEqual.js
src/lib/cancelablePromise.js -> dist/lib/cancelablePromise.js
src/lib/windowOrGlobal.js -> dist/lib/windowOrGlobal.js
=> Complete
joeyfigaro, omcg33, probabble, biosis21, and s-kennedy reacted with thumbs up emoji
joeyfigaro, s-kennedy, and christopher-theagen reacted with hooray emoji
All reactions
-
👍
5 reactions
-
🎉
3 reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Any reason this hasn't been merged?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
biosis21, lucas-pessoa, s-kennedy, and christopher-theagen reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.