GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix markers rerender when click to open InfoWindow by deadkff01 · Pull Request #310 · fullstackreact/google-maps-react

Conversation

@deadkff01

@deadkff01 deadkff01 commented Jan 28, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Solving issue #269

In Marker.js componentDidUpdate()

this.props.position and prevProps.position will never be equal after component is fully rendered in first time, because these properties are objects, for this reason I use the lat and lng to compare after the first rendering.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hurstindustries, FelixSchwarzmeier, NicksonT, julisalis, cesar-cb, alokyadav15, m-bartenev, and brodly reacted with thumbs up emoji
All reactions
  • 👍 8 reactions
@deadkff01
fix marker rerender
5077b3a
@m-bartenev

m-bartenev commented May 25, 2019

Copy link
Copy Markdown

@deadkff01 , I came across that issue recently. I did the same comparison but in shouldComponentUpdate method. Can I ask you why you've opted to the componentDidUpdate?
Thanks
deadkff01 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deadkff01

deadkff01 commented May 26, 2019

Copy link
Copy Markdown
Author

@m-bartenev, I did the comparison in componentDidUpdate only to keep the same code structure. :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@m-bartenev

m-bartenev commented May 26, 2019

Copy link
Copy Markdown

@deadkff01 , I see :) Thank you for your answer!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srobertson421

srobertson421 commented Jun 15, 2019

Copy link
Copy Markdown

To anyone who comes across this bug, here is a patch you can use until things are merged, should stop the constant re-renders:

class CustomMarker extends Marker {
  componentDidUpdate(prevProps) {
    if(
      this.props.map !== prevProps.map || 
      this.props.icon.url !== prevProps.icon.url || 
      (
        this.props.position.lat !== prevProps.position.lat || 
        this.props.position.lng !== prevProps.position.lng
      )
    ) {
      if(this.marker) {
        this.marker.setMap(null);
      }
      this.renderMarker();
    }
  }
}
deadkff01, shashank-naik, and Squdward reacted with thumbs up emoji markhowellsmead and Squdward reacted with rocket emoji
All reactions
  • 👍 3 reactions
  • 🚀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deadkff01

deadkff01 commented Aug 6, 2019

Copy link
Copy Markdown
Author

Nice @srobertson421
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sscholle
sscholle suggested changes Sep 2, 2020
View reviewed changes
Comment thread src/components/Marker.js Outdated
componentDidUpdate(prevProps) {
if ((this.props.map !== prevProps.map) ||
(this.props.position !== prevProps.position) ||
((this.props.position && prevProps.position)

@sscholle sscholle Sep 2, 2020

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most unreadable, please rather use a function such as 'arePositionsEqual' to simplify readability. thank you

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
deadkff01 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@deadkff01 deadkff01 Sep 2, 2020

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's been a long time, I'll see if this change still makes sense, if so, I'll make the change later.
Thanks for the feedback.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@deadkff01 deadkff01 Sep 3, 2020

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem still persists in the current version of the lib.

I solved your issue in the last commits.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
deadkff01 added 2 commits September 3, 2020 00:03
@deadkff01
feat(Marker): add verify marker position function
c71e463
@deadkff01
feat(Marker): add verify marker position function
c152cee

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sscholle sscholle sscholle requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@deadkff01 @m-bartenev @srobertson421 @sscholle
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.