GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Ref bug by nkov · Pull Request #336 · fullstackreact/google-maps-react

Conversation

@nkov

@nkov nkov commented Apr 5, 2019

Copy link
Copy Markdown

Use callback refs instead of string refs which have poor support in React 16+.

This solves #199.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
nkov added 2 commits April 5, 2019 17:14
@nkov
refbug
5e5051c
@nkov
update refs
2f174dd
FredrikAugust
FredrikAugust approved these changes Dec 5, 2019
View reviewed changes
@FredrikAugust

FredrikAugust commented Jan 16, 2020

Copy link
Copy Markdown

As it appears that the creators of this library have deserted it, and I depend on it at work, I will try to continue maintaining it at my personal fork. I have implemented your fix as well as some others.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@FredrikAugust FredrikAugust FredrikAugust approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nkov @FredrikAugust
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.