GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add missing props and types by abraha2d · Pull Request #338 · fullstackreact/google-maps-react

Conversation

@abraha2d

@abraha2d abraha2d commented Apr 15, 2019

Copy link
Copy Markdown

Added following types on Marker component: onDblclick, onDragend, onMousedown, onMouseout, onMouseup, onRecenter

Added following props on Map component: mapTypeId, scaleControlOptions, streetView, panControlOptions, rotateControlOptions, fullscreenControlOptions, draggingCursor, backgroundColor, heading, overviewMapControl, overviewMapControlOptions, signInControl, tilt

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
abraha2d added 6 commits April 15, 2019 09:47
@abraha2d
Add backgroundColor prop
5aefd08
@abraha2d
Add a whole bunch more missing props
c3ce2fa
@abraha2d
Fix camelization
3f6aa4d
@abraha2d
Transpile
0053f87
@abraha2d
Add marker event handler types
1fd14e5
@abraha2d
Re-order config and proptypes to minimize diff
f1e1200
@abraha2d

abraha2d commented Apr 15, 2019

Copy link
Copy Markdown
Author

Just noticed, but this PR supersedes #313, #301, #222, and #220.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abraha2d
Fix unnecessary marker re-render
f167016
@abraha2d
abraha2d force-pushed the master branch from f970bb7 to f167016 Compare April 15, 2019 19:42

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@abraha2d
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.