GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Updated polyline and polygon to re-render on props change by sselfridge · Pull Request #341 · fullstackreact/google-maps-react

Conversation

@sselfridge

@sselfridge sselfridge commented Apr 27, 2019

Copy link
Copy Markdown

Previously polygons/polylines weren't checking the props to see if they need to re-render when component did update.

Added in propChanged function, similar to the way circle is handled in commit: c5de2a7

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sam Selfridge added 2 commits April 27, 2019 09:50
Sam Selfridge Sam Selfridge
Adding propsChanged function to polyline and polygons
2f14396 
ensures that changes to color/visibility/etc will trigger a re-render
Sam Selfridge Sam Selfridge
Adding dist/components for polygon and polyline with propChanged() fu…
6c7a7dd 
…nction
@sselfridge sselfridge mentioned this pull request Apr 27, 2019
Polyline and Polygons do not re-render on props change #342
Open
@Langley1996 Langley1996 mentioned this pull request Jan 27, 2021
Polyline doesn't rerender after change strokeColor or other properties #501
Open
Sam Selfridge added 5 commits May 25, 2022 14:18
Sam Selfridge
2.0.7 build
eae7088
Sam Selfridge
Merge branch 'master' into master2.0.7
09acbe5
Sam Selfridge
don't need lthat lil feller
c184c70
Sam Selfridge
don't need that guy either
e9d35c8
Sam Selfridge
Merge branch 'master2.0.7'
a5dd602

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@sselfridge
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.