GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add more event listener for Marker by yonasadiel · Pull Request #456 · fullstackreact/google-maps-react

Conversation

@yonasadiel

@yonasadiel yonasadiel commented Jul 4, 2020

Copy link
Copy Markdown

Based on this code, the Marker can accept some more event listener. However, only onClick and onMouseover are listed on typescript definition.

google-maps-react/src/components/Marker.js

Lines 97 to 104 in 5038ac4

handleEvent(evt) {
return (e) => {
const evtName = `on${camelize(evt)}`
if (this.props[evtName]) {
this.props[evtName](this.props, this.marker, e);
}
}
}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@yonasadiel
Add more event listener for Marker
bf12ecb
@yonasadiel

yonasadiel commented Jul 4, 2020

Copy link
Copy Markdown
Author

Ups, I think this is duplicate of #433

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@yonasadiel yonasadiel closed this Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@yonasadiel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.