GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — upgrade react to 16 by ajkovar · Pull Request #459 · fullstackreact/google-maps-react

Conversation

@ajkovar

@ajkovar ajkovar commented Jul 11, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

I was seeing "React.createRef is not a function" on a fresh clone after running npm install and launching the dev server. Seems the deps were pointing at React 15 but in the code there are a references to React.createRef, which requires React 16.

Then I upgraded a couple other packages while I was in there since there were some npm audit problems.

After making this change and reinstalling, and then making a small adjustment to the tests to support React 16, everything works.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ajkovar
ajkovar force-pushed the upgrade-deps branch from 7d4cc28 to 3534090 Compare July 11, 2020 10:29
@ajkovar
upgrade react to 16
b42de4f
@ajkovar
ajkovar force-pushed the upgrade-deps branch from 3534090 to b42de4f Compare July 11, 2020 10:42
@ajkovar
update mocha and eslint
7c265aa
@ajkovar
ajkovar force-pushed the upgrade-deps branch from 7aab391 to 7c265aa Compare July 11, 2020 12:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ajkovar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.