GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Parity of response format between ios and android by chaitanya-bhagavan · Pull Request #119 · fullstackreact/react-native-firestack

Conversation

@chaitanya-bhagavan

@chaitanya-bhagavan chaitanya-bhagavan commented Nov 8, 2016

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
chaitanya-bhagavan added 4 commits November 8, 2016 19:24
@chaitanya-bhagavan
Catch exception thrown by setPersistenceEnabled which was causing the…
972b16d 
… rn app to fail
@chaitanya-bhagavan
Parity in response format between ios and android
a4a115f
@chaitanya-bhagavan
Fixed a typo that was causing an error
483e15f
@chaitanya-bhagavan
Parity in response format between ios and android
a85f5fa
mikesurowiec
mikesurowiec reviewed Nov 9, 2016
View reviewed changes
Comment thread lib/modules/database.js Outdated
return this.db.off(path, evt, origCB)
.then(({callback, subscriptions}) => {
if (dbSubscriptions[path] && dbSubscriptions[path][evt].length > 0) {
if (subscriptions[path] && subscriptions[path][evt].length > 0) {

@mikesurowiec mikesurowiec Nov 9, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what error you were seeing, but by changing this to subscriptions, it becomes functionally broken since we want to remove the JS callbacks from the global dbSubscriptions set. The subscriptions you referenced comes from: https://github.com/chaitanya0bhagvan/react-native-firestack/blob/483e15fd4b7a8256bec99771220c4cc9721e198a/lib/modules/database.js#L490. Probably needs a better name though!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chaitanya-bhagavan
Reverted changes since it was an error from my end
e34988b
auser
auser approved these changes Nov 9, 2016
View reviewed changes

@auser auser left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@auser
auser merged commit ea5e10c into fullstackreact:master Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@mikesurowiec mikesurowiec mikesurowiec left review comments
@auser auser auser approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@chaitanya-bhagavan @auser @mikesurowiec
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.