GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Android listenForAuth method to correctly check for user by ghuh · Pull Request #124 · fullstackreact/react-native-firestack

Conversation

@ghuh

@ghuh ghuh commented Nov 10, 2016

Copy link
Copy Markdown
Contributor

listenForAuth was not correctly checking for a user object so the user object was never populated on the callback.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghuh
Fix Android listenForAuth method to correctly check for user
c3129fb
auser
auser reviewed Nov 10, 2016
View reviewed changes

@auser auser left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... I'll check it out

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghuh

ghuh commented Nov 10, 2016

Copy link
Copy Markdown
Contributor Author

The old code may have worked in certain scenarios where the user instance variable had already been set. However, it was guaranteed to fail when setting listenForAuth on app startup to see if a user is already logged in.

This new code will work in all scenarios.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
auser
auser approved these changes Nov 11, 2016
View reviewed changes
@auser
auser merged commit c811a3a into fullstackreact:master Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@auser auser auser approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ghuh @auser
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.