GeezerVison is showing github.com — Use storage url from .plist file if not setStorageUrl() hasn't been called by janvogt · Pull Request #143 · fullstackreact/react-native-firestack
Conversation
janvogt
commented
Nov 17, 2016
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
- Fix weird error that NSError is not KVC compliant when storage is not configured in
JS
- Fixed code seems to exist on several more locations but has not been fixed,
since there are no tests to ensure I don't break anything.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…alled.
- Fix weird error that NSError is not KVC compliant when storage is not configured
JS
- Fixed code seems to exist on several more locations but has not been fixed,
since there are no tests to ensure I don't break anything.
- Use storageUrl from default config if not set otherwise in JS
- Similar code exists on several other places that are not fixed since
no tests prevent breaking stuff.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.