GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added RemoteConfig API by Jeanmsilva89 · Pull Request #145 · fullstackreact/react-native-firestack

Conversation

@Jeanmsilva89

@Jeanmsilva89 Jeanmsilva89 commented Nov 18, 2016

Copy link
Copy Markdown

Re-added RemoteConfig feature.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rigobcastro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Jeanmsilva89
Added RemoteConfig API
a971038
@mikelambert

mikelambert commented Nov 26, 2016

Copy link
Copy Markdown
Contributor

It seems configValueForKey only gets the stringValue of an item?

Before I discovered firestack, I had built out a firebase3 module myself for the remoteconfig and analytics stuff I had needed. If you're motivated to get this implemented, perhaps you'd be interested in stealing my remoteconfig code?

https://github.com/mikelambert/react-native-firebase3/blob/master/android/src/main/java/org/jall/reactnative/firebase/RNFIRRemoteConfig.java

https://github.com/mikelambert/react-native-firebase3/blob/master/ios/Firebase/RNFIRRemoteConfig.m

It definitely works in iOS, and I'm pretty sure it works in Android (my app is broken w.r.t. this right now, but I believe that's due to the recent inclusion of both rn-firestack and rn-firebase3 in my project, both trying to initialize fb under-the-hood)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SuperBesse

SuperBesse commented Dec 8, 2016

Copy link
Copy Markdown

Hi,
have you an idea when this PR will be available ?

neacsugeorge reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nkashyap

nkashyap commented Dec 22, 2016

Copy link
Copy Markdown

+1 for both ios & android

neacsugeorge reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatras

chatras commented Dec 31, 2016

Copy link
Copy Markdown

When will this be available? Great work so far guys! Loving this library!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@matts2cant

matts2cant commented Feb 5, 2017

Copy link
Copy Markdown

Hi ! Do you know when you plan on releasing this ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nkashyap

nkashyap commented Feb 5, 2017

Copy link
Copy Markdown

Here is PR for v3

Salakar#12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Jeanmsilva89 @mikelambert @SuperBesse @nkashyap @chatras @matts2cant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.