GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Corrections in docs, auth and database subscription bug fixes for iOS/Android by abcd-ca · Pull Request #284 · fullstackreact/react-native-firestack

Conversation

@abcd-ca

@abcd-ca abcd-ca commented Feb 8, 2017

Copy link
Copy Markdown

A couple mistakes in the docs that I tracked down in terms of keys and values for credentials. I have facebook auth working in my app now as a result of these changes (I've verified)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
abcd-ca added 3 commits February 8, 2017 11:51
@abcd-ca
Corrections in docs
ef1b18b 
A couple mistakes in the docs that I tracked down in terms of keys and values for credentials.
@abcd-ca
Fixed facebook/google provider strings
2b944b8 
Changed from facebook and google to facebook.com and google.com respectively. This is needed for cross platform apps. These strings are now consistent with the [iOS](https://github.com/fullstackreact/react-native-firestack/blob/v3/ios/Firestack/FirestackAuth.m#L444) and [Web](https://firebase.google.com/docs/reference/js/firebase.auth.AuthCredential) code. Docs should be updated too. [Here's my pull request](https://github.com/fullstackreact/react-native-firestack/pull/284/files) for that.
@abcd-ca
API bug fix for signInWithCredential
3c892e8 
Solution discovered by @TheNarie in [this issue](fullstackreact#282) except I also corrected `accessToken` from the original suggestion. Docs also updated about that in same pull request.
@abcd-ca abcd-ca mentioned this pull request Feb 13, 2017
signInWithProvider argument mismatch #282
Open
@abcd-ca abcd-ca changed the title Corrections in docs Corrections in docs and bug fixes Feb 13, 2017
abcd-ca added 3 commits February 13, 2017 11:47
@abcd-ca
Fix for iOS and Android compatibility
98a3d2c 
The iOS and Android, `signInWithProvider` have different signatures. This works around that difference but ideally the native signatures should match each other (and the Web sdk's). Tested on iOS and Android.
@abcd-ca
Forgot to import Platform
8e79615 
needed for previous commit.
@abcd-ca
Bug fix in Android for dbRef.on('value'...)
d47aecb 
One of the needed parameters was named incorrectly – on Android this resulted in no data being retrieved. This fixes it.
@abcd-ca abcd-ca mentioned this pull request Feb 13, 2017
ref.on('value'.....) not working on Android (solved in PR) #287
Open
@abcd-ca

abcd-ca commented Feb 13, 2017

Copy link
Copy Markdown
Author

created issue to reference this PR about ref.on('value'...) bug fix
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abcd-ca abcd-ca changed the title Corrections in docs and bug fixes Corrections in docs, auth and database subscription bug fixes for iOS/Android Feb 13, 2017
v1kku
v1kku reviewed Feb 16, 2017
View reviewed changes
Comment thread lib/modules/auth/index.js Outdated
*/
signInWithCredential(credential: any): Promise<Object> {
return promisify('signInWithProvider', FirestackAuth)(credential.provider, credential.accessToken, credential.secret);
signInWithCredential(credential: any): Promise<Object> {

@v1kku v1kku Feb 16, 2017

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abcd-ca This line is duplicated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@abcd-ca
Fixed duplicate line
651ffdf
@abcd-ca

abcd-ca commented Feb 16, 2017 via email

Copy link
Copy Markdown
Author
Good catch, I fixed the duplicate line.
…
On Feb 16, 2017, at 5:35 AM, Victor Munene ***@***.***> wrote: @v1kku commented on this pull request. In lib/modules/auth/index.js <#284 (comment)>: > @@ -151,7 +151,12 @@ export default class Auth extends Base { * @return {Promise} A promise resolved upon completion */ signInWithCredential(credential: any): Promise<Object> { - return promisify('signInWithProvider', FirestackAuth)(credential.provider, credential.accessToken, credential.secret); + signInWithCredential(credential: any): Promise<Object> { @abcd-ca <https://github.com/abcd-ca> This line is duplicated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#284 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPG5ysoPvPP0iQYRn6lsYVN6YEMlWUTks5rdFCtgaJpZM4L7SE_>.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alexkendall

alexkendall commented Mar 2, 2017

Copy link
Copy Markdown

+1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@JackThomson2

JackThomson2 commented Mar 18, 2017

Copy link
Copy Markdown

+1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Salakar

Salakar commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

@abcd-ca @alexkendall @JackThomson2 this repo has generally been abandoned, I think this issue and a ton of other issues were fixed in my v3 version of firestack.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@v1kku v1kku v1kku left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@abcd-ca @alexkendall @JackThomson2 @Salakar @v1kku
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.