GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix blank code / message due to wrong variable names by jsbranco · Pull Request #304 · fullstackreact/react-native-firestack

Conversation

@jsbranco

@jsbranco jsbranco commented Mar 6, 2017

Copy link
Copy Markdown

I am not too familiar with Objective-C however, I was having this issue where createUserWithEmailPassword, was returning code:"" and message:"". While debugging the FirebaseAuth file I noticed the discrepancy in variable names. After refactoring them the error code is shown as expected:

screen shot 2017-03-06 at 22 59 49

Do let me know if there are any concerns with this change?

Kind Regards
Junio

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
designorant and recurrence reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@jsbranco jsbranco mentioned this pull request Mar 6, 2017
[V3] ios login errors from loginWithEmailAndPassword coming back as undefined #288
Open
@jsbranco
jsbranco force-pushed the v3 branch 2 times, most recently from bd859cf to 447108c Compare March 7, 2017 19:33
Junio Branco Junio Branco
Fix blank error code
54a26af
@jsbranco
jsbranco force-pushed the v3 branch from 447108c to 54a26af Compare March 7, 2017 19:35
Junio Branco added 2 commits March 8, 2017 03:36
Junio Branco Junio Branco
Refactor casting
3e74908
Junio Branco Junio Branco
Fix for signInWithEmailPassword which was throwing the following erro…
948b882 
…r : 'code.toLowerCase not a function'
@jsbranco

jsbranco commented May 16, 2017

Copy link
Copy Markdown
Author

Is there any plans to integrate this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@jsbranco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.