GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — configureWithOptions fix for android by BodySplash · Pull Request #336 · fullstackreact/react-native-firestack

Conversation

@BodySplash

@BodySplash BodySplash commented Apr 28, 2017

Copy link
Copy Markdown

When a google-services.json is provided, Firestack auto-configures itself (see this article), so there is no way to pass custom options afterwards.

Removing the google-services.json didn't solve the issue, since building a FirebaseOptions without an applicationId throws an exception.

This patch detects if the firebase default app is already configured, otherwise uses params to set it up, without trying to build an empty FirebaseOptions.
Il also refactored a little bit the way params keys are searched to be complient with the params in the ios version.
I think this patch might resolve most of the "FirebaseApp[DEFAULT] already configured" errors in android apps, like in #265

Maybe the README should be updated to state clearly that .plist/.json and options from js are mutually exclusives way to configure firestack.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jbesse and others added 3 commits April 13, 2017 14:33
jbesse
[Android config]: update build.gradle to use 10.0.1 of play services.
31290ff
jbesse
[Gradle configuration]: update playservices to 10.2.1
361807a
@BodySplash
trying to avoid init error when no google-services.json file is provided
3ed2ba1
@Salakar

Salakar commented May 3, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

You're probably best off tackling this on my v3 fork of firestack if possible due to the current state of affairs here

v3: https://github.com/Salakar/react-native-firestack
baba43 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BodySplash

BodySplash commented May 16, 2017

Copy link
Copy Markdown
Author

hum why not. Since you dropped all options passing, it will require a little more work to include my PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@BodySplash @Salakar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.