GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace deprecated ThrowableProxy with LogEvent#getThrown() in sentry-log4j2 by sahasan95 · Pull Request #5751 · getsentry/sentry-java

Conversation

@sahasan95

@sahasan95 sahasan95 commented Jul 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

…-log4j2

📜 Description

Replaces the deprecated ThrowableProxy class with LogEvent#getThrown() in SentryAppender.

💡 Motivation and Context

ThrowableProxy is deprecated in log4j2. The only usage in SentryAppender was calling
.getThrowable() on it to extract the underlying Throwable. LogEvent already exposes
this directly via getThrown(), which is documented as a convenience method for exactly
that purpose, so ThrowableProxy can be dropped entirely.

  • resolves: Using deprecation in sentry-log4j2 #5439

💚 How did you test it?

Ran the existing sentry-log4j2 test suite (./gradlew :sentry-log4j2:test) — all tests pass.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

N/A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sentry[bot] reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@sahasan95
sahasan95 requested review from 0xadam-brown, adinauer, markushi, romtsn and runningcode as code owners July 9, 2026 19:25
@sahasan95
Replace deprecated ThrowableProxy with LogEvent#getThrown() in sentry…
282b7a3
…-log4j2
@sahasan95
sahasan95 force-pushed the fix/log4j2-throwableproxy-deprecation branch from b2270a2 to 282b7a3 Compare July 9, 2026 20:19
markushi
markushi reviewed Jul 10, 2026
View reviewed changes

@markushi markushi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you add entry to CHANGELOG.md as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread sentry-log4j2/src/main/java/io/sentry/log4j2/SentryAppender.java Resolved

Uh oh!

There was an error while loading. Please reload this page.

sahasan95 and others added 2 commits July 10, 2026 20:36
@sahasan95
Add @nullable annotation and CHANGELOG entry
86cad0d
@adinauer
Merge branch 'main' into fix/log4j2-throwableproxy-deprecation
1b149b5
adinauer
adinauer approved these changes Jul 22, 2026
View reviewed changes

@adinauer adinauer left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adinauer
adinauer merged commit e82419d into getsentry:main Jul 22, 2026
65 checks passed

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Jul 22, 2026
publish: getsentry/[email protected] getsentry/publish#8956
Closed
publish: getsentry/[email protected] getsentry/publish#8957
Closed
publish: getsentry/[email protected] getsentry/publish#8958
Closed
@github-actions github-actions Bot mentioned this pull request Jul 22, 2026
Using deprecation in sentry-log4j2 #5439
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markushi markushi markushi left review comments
@adinauer adinauer adinauer approved these changes
@romtsn romtsn Awaiting requested review from romtsn
@runningcode runningcode Awaiting requested review from runningcode
@0xadam-brown 0xadam-brown Awaiting requested review from 0xadam-brown

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using deprecation in sentry-log4j2

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sahasan95 @markushi @adinauer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.