GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — ref(android): Extract ANR culprit exceptions into AnrCulpritEventHelper by markushi · Pull Request #6593 · getsentry/sentry-java Conversation
Member
📜 DescriptionMoves the code that turns an ANR profile culprit into event exceptions out of
The fatal ANR event does not change. 💡 Motivation and ContextPrep work for non-fatal ANRs. The non-fatal ANR event needs the same culprit exception and fingerprint rule as the fatal one, so both event producers will share this helper. 💚 How did you test it?Added 📝 Checklist
🔮 Next stepsThe non-fatal ANR integration will use this helper. #skip-changelog 🤖 Generated with Claude Code
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
📲 Install BuildsAndroid
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| */ | ||
| final class ApplicationNotResponding extends RuntimeException { | ||
| @ApiStatus.Internal | ||
| public final class ApplicationNotResponding extends RuntimeException { |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
had to change the visibility, otherwise the helper could not have accessed it. Moving this class probably isn't an option, as it's used for captureException() and thus could influence issue grouping.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
One quick question in case it's helpful; otherwise lgtm 👍
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| @ApiStatus.Internal | ||
| public final class AnrCulpritEventHelper { |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I imagine I'll learn more as more PRs emerge, but (for now) it looks like there's a lot of overlap between this class an the existing AnrCulpritIdentifier. Just making sure we don't want to extend the latter instead?
(Happy to defer to you.)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
At least 1 approving review is required to merge this pull request.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.