GeezerVison is showing github.com — Revert "ci(deps): Dedupe lockfile on Dependabot PRs (#25911)" (#25962) · getsentry/sentry-javascript@b63640b
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: .github/workflows/build.yml +2-5Lines changed: 2 additions & 5 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -1141,16 +1141,13 @@ jobs: |
1141 | 1141 | # them. optional-e2e.yml reports the results in a PR comment. |
1142 | 1142 | job_optional_e2e_tests: |
1143 | 1143 | name: E2E Tests (optional) |
1144 | | - # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks. |
1145 | | - # Dependabot PRs are skipped by author, not by `github.actor`: once the Gitflow app pushes the deduped lockfile |
1146 | | - # (dependabot-dedupe-push.yml), the actor is the app and the run would otherwise get the E2E secrets. |
| 1144 | + # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks |
1147 | 1145 | # We need to add the `always()` check here because the previous step has this as well :( |
1148 | 1146 | # See: https://github.com/actions/runner/issues/2205 |
1149 | 1147 | if: |
1150 | 1148 | always() && needs.job_get_metadata.outputs.is_release != 'true' && needs.job_build_tarballs.result == 'success' && |
1151 | 1149 | needs.job_build.outputs.e2e-matrix-optional != '{"include":[]}' && (github.event_name != 'pull_request' || |
1152 | | - github.event.pull_request.head.repo.full_name == github.repository) && github.event.pull_request.user.login != |
1153 | | - 'dependabot[bot]' |
| 1150 | + github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]' |
1154 | 1151 | needs: [job_get_metadata, job_build, job_build_tarballs] |
1155 | 1152 | # This job only waits for optional-e2e.yml, which can take most of an hour. GitHub runners are free for public |
1156 | 1153 | # repos and Namespace runners are paid per minute, so the wait runs here and the tests run on Namespace. |
|
Collapse file
Copy file name to clipboardExpand all lines: .github/workflows/dependabot-dedupe-push.yml -134Lines changed: 0 additions & 134 deletions Collapse file
Copy file name to clipboardExpand all lines: .github/workflows/dependabot-dedupe.yml -63Lines changed: 0 additions & 63 deletions