GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(server-runtime-injection): Register the CJS loader hook from the CJS build by timfish · Pull Request #26278 · getsentry/sentry-javascript

Conversation

@timfish

@timfish timfish commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

On Node < 24.13, the CJS build of register.ts passed build/esm/hook.js to Module.register(). Turbopack ships that file in the Next.js server trace but does not follow its imports, so the loader thread could not find build/esm/vendored/** or the ESM build of @sentry/core. Registration then warned on every cold start.

The CJS build now registers build/cjs/hook.js, which the package already built but did not use. That file only requires chunks that register.js requires too, so a tracer that ships a working register.js always ships them. Node accepts a CJS module as a Module.register() target. This is an alternative to #26271: the package does not grow and no Next.js config is needed.

The data: URL loader that forced the ESM format for build/esm is removed. It only helped the CJS build load the ESM hook when a deployment dropped build/esm/package.json, and the CJS build no longer loads anything from build/esm. The ESM build still registers the ESM hook.

The new test/hook.test.ts registers the hook from a copy that ships only build/cjs. The nextjs-16-standalone build-output test (taken from #26271) forces the Module.register() path against the real Turbopack standalone output. Both fail on develop with the error from the issue.

Closes #26121

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@timfish
fix(server-runtime-injection): Register the CJS loader hook from the …
76cccea
…CJS build

On Node < 24.13 the CJS build passed build/esm/hook.js to Module.register(). Turbopack ships that file but not the files it imports, so registration failed in Next.js standalone output.

The CJS build now registers build/cjs/hook.js. That file only requires chunks that register.js requires too, so every tracer ships them. The loader that forced the ESM format for build/esm is no longer needed.
@timfish timfish mentioned this pull request Nov 11, 2026
fix(server-runtime-injection): Bundle the ESM loader hook into one self-contained file #26271
Closed
@timfish
timfish marked this pull request as ready for review November 11, 2026 10:24
@timfish
timfish requested review from a team, JPeer264 and stephanie-anderson November 11, 2026 10:24
@timfish
timfish requested a review from a team as a code owner November 11, 2026 10:24
@timfish
timfish requested review from mydea and removed request for a team November 11, 2026 10:24
@github-actions

github-actions Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: f8134e0 (PR test merge using develop at 621a801)

Against: 621a801 (develop) · base run #65856

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.04 kB - -
@sentry/browser - with treeshaking flags 28.23 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.12 kB - -
@sentry/browser (incl. Tracing) 52.2 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.2 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.17 kB - -
@sentry/browser (incl. Tracing, Replay) 92.73 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.52 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.08 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.51 kB - -
@sentry/browser (incl. Feedback) 47.66 kB - -
@sentry/browser (incl. sendFeedback) 30.62 kB - -
@sentry/browser (incl. FeedbackAsync) 35.62 kB - -
@sentry/browser (incl. Metrics) 31.36 kB - -
@sentry/browser (incl. Logs) 31.64 kB - -
@sentry/browser (incl. Metrics & Logs) 32.3 kB - -
@sentry/react 32.04 kB - -
@sentry/react (incl. Tracing) 54.86 kB - -
@sentry/vue 38.21 kB - -
@sentry/vue (incl. Tracing) 55.14 kB - -
@sentry/svelte 30.05 kB - -
@sentry/remix (Remix 3 client bundle) 57.96 kB - -
CDN Bundle 31.79 kB - -
CDN Bundle (incl. Tracing) 52.58 kB - -
CDN Bundle (incl. Logs, Metrics) 34.58 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.14 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.61 kB - -
CDN Bundle (incl. Tracing, Replay) 90.63 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.25 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.6 kB - -
CDN Bundle - uncompressed 92.69 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.13 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.03 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 162.76 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 231.11 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.27 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 282.9 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.07 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 294.69 kB - -
@sentry/nextjs (client) 58.23 kB - -
@sentry/sveltekit (client) 53.26 kB - -
@sentry/core/server 44.53 kB - -
@sentry/core/browser 13.99 kB - -
@sentry/node 149.35 kB -0.09% -128 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.18 kB -0.15% -119 B 🔽
@sentry/node - without tracing 88.27 kB -0.13% -111 B 🔽
@sentry/node - without channel injection 138.45 kB -0.01% -3 B 🔽
@sentry/aws-serverless 97.19 kB -0.12% -111 B 🔽
@sentry/cloudflare (withSentry) - minified 204.35 kB - -
@sentry/cloudflare (withSentry) 474.32 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 229.66 kB - -

View base workflow run

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@timfish
timfish requested review from isaacs and removed request for stephanie-anderson November 11, 2026 10:27
cursor[bot]
cursor Bot reviewed Nov 11, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 76cccea. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread packages/server-runtime-injection/src/register.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread dev-packages/e2e-tests/test-applications/nextjs-16-standalone/tests/build-output.test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@timfish
test(server-runtime-injection): Check that the CJS hook requires only…
78c1106
… files register.js requires
@github-actions

github-actions Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 4 not successful, 46 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E node-eve (orchestrion) Test (optional) Failing after 2m Details
❌ CI: Optional E2E Tests / E2E nextjs-16-cacheComponents (cloudflare) Test (optional) Failing after 10m Details
❌ CI: Optional E2E Tests / E2E node-eve (latest) Test (optional) Failing after 2m Details
❌ CI: Optional E2E Tests / E2E node-eve Test (optional) Failing after 2m Details
Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nestjs-12 (bun) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E deno (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nestjs-12 (deno) Test (optional) Successful in 52s Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions (latest) Test (optional) Successful in 32s Details
✅ CI: Optional E2E Tests / E2E nestjs-12 (cloudflare) Test (optional) Successful in 38s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (deno) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries Test (optional) Successful in 51s Details
✅ CI: Optional E2E Tests / E2E debug-id-sourcemaps Test (optional) Successful in 33s Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries (cloudflare) Test (optional) Successful in 41s Details
✅ CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-express-send-to-sentry-static Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nestjs-12 (latest) Test (optional) Successful in 58s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v1 Test (optional) Successful in 29s Details
✅ CI: Optional E2E Tests / E2E node-flue Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries (latest) Test (optional) Successful in 52s Details
✅ CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) Successful in 59s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 31s Details
✅ CI: Optional E2E Tests / E2E node-express-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-mastra Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-cloudflare Test (optional) Successful in 31s Details
✅ CI: Optional E2E Tests / E2E node-pi-durable (latest) Test (optional) Successful in 34s Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v2 Test (optional) Successful in 27s Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions Test (optional) Successful in 26s Details
✅ CI: Optional E2E Tests / E2E node-mastra (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-flue (latest) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 Test (optional) Successful in 30s Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 (tracer provider) Test (optional) Successful in 32s Details
✅ CI: Optional E2E Tests / E2E node-pi-durable Test (optional) Successful in 36s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E solidstart-2 Test (optional) Successful in 57s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 34s Details
✅ CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 36s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 36s Details
✅ CI: Optional E2E Tests / E2E nuxt-5 (tunnel-dev) Test (optional) Successful in 51s Details
✅ CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 34s Details
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

isaacs
isaacs approved these changes Nov 11, 2026
View reviewed changes

@isaacs isaacs left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared with #26271, this is smaller, has fewer moving parts, and does not bring in the debug browser code or the 3.5 MB source map. Its one weak point was that it depended on a chunking fact no test checked. The second commit now checks that for the CJS build, which is the build Next.js loads. I would prefer this PR over #26271. After a CI re-run, and with the test cleanups, it is ready to land.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread packages/server-runtime-injection/src/hook.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread packages/server-runtime-injection/test/hook.test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread packages/server-runtime-injection/test/hook.test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

timfish and others added 4 commits November 11, 2026 11:14
@timfish @isaacs
Update packages/server-runtime-injection/src/hook.mjs
d8e50b3
Co-authored-by: isaacs <[email protected]>
@timfish
test(server-runtime-injection): Copy the CJS build to the temp direct…
4835e0a
…ory in the hook test

The copy is made in beforeAll under os.tmpdir(), so a killed run leaves no duplicate package in the repo. The child script reads the marker directly, because Module.register() throws on the main thread. Also fixes a doubled word in the hook.mjs comment.
@timfish
Merge branch 'develop' into fix/server-runtime-injection-cjs-loader-hook
6cf6848
@timfish
Merge branch 'develop' into fix/server-runtime-injection-cjs-loader-hook
9fdb4bd
@timfish
timfish enabled auto-merge (squash) November 12, 2026 13:25
@timfish
fix(server-runtime-injection): Export only the loader hook functions …
de83eb2
…from the hook entry

With rolldown, export * emitted a build/cjs/hook.js that read an undefined import_diagnostics binding, so the CJS hook failed to load. Module.register() only reads initialize, load and resolve, so the entry now exports those three.
@timfish
timfish merged commit f49009b into develop Nov 12, 2026
333 of 337 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@timfish
timfish deleted the fix/server-runtime-injection-cjs-loader-hook branch November 12, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@isaacs isaacs isaacs approved these changes
@JPeer264 JPeer264 Awaiting requested review from JPeer264 JPeer264 was automatically assigned from getsentry/team-javascript-sdks
@mydea mydea Awaiting requested review from mydea mydea is a code owner automatically assigned from getsentry/team-javascript-sdks-server

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

server-runtime-injection: ESM hook's vendored imports and @sentry/core ESM build are not traced on Next.js/Vercel, so registration fails on every cold start

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@timfish @isaacs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.