GeezerVison is showing github.com — chore(dev-deps): Replace nodemon with tsx watch by sentry-junior[bot] · Pull Request #26322 · getsentry/sentry-javascript
Conversation
Why: nodemon was only used by two build:transpile:watch scripts, and both were broken:
- In
nextjs, nodemon ran scripts/buildRollup.ts through ts-node, which isn't installed ("ts-node" exec not found).
- In
tanstackstart-react, the script points at a scripts/buildRollup.ts that doesn't exist, so nodemon ran the package's main and never built anything.
nextjs now uses tsx watch with the same tsconfig its build:transpile already uses. --include src replaces --watch src, because tsx only watches files the script imports, and buildRollup shells out to rolldown. --clear-screen=false keeps nx's interleaved watch output readable. tanstackstart-react's build:transpile is a plain rolldown call, so its watch is now rolldown --watch, like the other 36 packages.
The "Debug playwright tests" VS Code launch config, the last nodemon reference, is removed rather than ported. It pointed at a playwright binary path that no longer exists, and no package under packages/ has playwright tests anymore.
How to review: Two script lines, the launch config, and the lockfile. Verified locally: the nextjs watch builds once, rebuilds once after touching a src file, and doesn't loop on its own build/ output. The tanstackstart-react watch builds without errors.
via @mydea.
--
View Session [Sentry]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Both nodemon watch scripts were broken: in nextjs nodemon ran the
script through ts-node, which is not installed, and tanstackstart-react
pointed at a scripts/buildRollup.ts that does not exist.
nextjs now uses tsx watch with the tsconfig its build:transpile already
uses, and tanstackstart-react watches with rolldown like the other
packages whose build:transpile is a plain rolldown call.
Co-Authored-By: Francesco Gringl-Novy <[email protected]>
size-limit report 📦
Compared: f146281 (PR test merge using develop at 359fbe4)
Against: 359fbe4 (develop) · base run #65839
✅ Baseline matches: this diff contains only this PR's changes.
| Path |
Size |
% Change |
Change |
| @sentry/browser |
30.04 kB |
- |
- |
| @sentry/browser - with treeshaking flags |
28.23 kB |
- |
- |
| @sentry/browser - with treeshaking flags tracing without tracing |
28.12 kB |
- |
- |
| @sentry/browser (incl. Tracing) |
52.2 kB |
- |
- |
| @sentry/browser (incl. Tracing + Span Streaming) |
52.2 kB |
- |
- |
| @sentry/browser (incl. Tracing, Profiling) |
55.17 kB |
- |
- |
| @sentry/browser (incl. Tracing, Replay) |
92.73 kB |
- |
- |
| @sentry/browser (incl. Tracing, Replay) - with treeshaking flags |
81.52 kB |
- |
- |
| @sentry/browser (incl. Tracing, Replay with Canvas) |
97.08 kB |
- |
- |
| @sentry/browser (incl. Tracing, Replay, Feedback) |
110.51 kB |
- |
- |
| @sentry/browser (incl. Feedback) |
47.66 kB |
- |
- |
| @sentry/browser (incl. sendFeedback) |
30.62 kB |
- |
- |
| @sentry/browser (incl. FeedbackAsync) |
35.62 kB |
- |
- |
| @sentry/browser (incl. Metrics) |
31.36 kB |
- |
- |
| @sentry/browser (incl. Logs) |
31.64 kB |
- |
- |
| @sentry/browser (incl. Metrics & Logs) |
32.3 kB |
- |
- |
| @sentry/react |
32.04 kB |
- |
- |
| @sentry/react (incl. Tracing) |
54.86 kB |
- |
- |
| @sentry/vue |
38.21 kB |
- |
- |
| @sentry/vue (incl. Tracing) |
55.14 kB |
- |
- |
| @sentry/svelte |
30.05 kB |
- |
- |
| @sentry/remix (Remix 3 client bundle) |
57.96 kB |
- |
- |
| CDN Bundle |
31.79 kB |
- |
- |
| CDN Bundle (incl. Tracing) |
52.58 kB |
- |
- |
| CDN Bundle (incl. Logs, Metrics) |
34.58 kB |
- |
- |
| CDN Bundle (incl. Tracing, Logs, Metrics) |
55.14 kB |
- |
- |
| CDN Bundle (incl. Replay, Logs, Metrics) |
75.61 kB |
- |
- |
| CDN Bundle (incl. Tracing, Replay) |
90.63 kB |
- |
- |
| CDN Bundle (incl. Tracing, Replay, Logs, Metrics) |
93.25 kB |
- |
- |
| CDN Bundle (incl. Tracing, Replay, Feedback) |
96 kB |
- |
- |
| CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) |
98.6 kB |
- |
- |
| CDN Bundle - uncompressed |
92.69 kB |
- |
- |
| CDN Bundle (incl. Tracing) - uncompressed |
155.13 kB |
- |
- |
| CDN Bundle (incl. Logs, Metrics) - uncompressed |
101.03 kB |
- |
- |
| CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed |
162.76 kB |
- |
- |
| CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed |
231.11 kB |
- |
- |
| CDN Bundle (incl. Tracing, Replay) - uncompressed |
275.27 kB |
- |
- |
| CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed |
282.9 kB |
- |
- |
| CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed |
287.07 kB |
- |
- |
| CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed |
294.69 kB |
- |
- |
| @sentry/nextjs (client) |
58.23 kB |
- |
- |
| @sentry/sveltekit (client) |
53.26 kB |
- |
- |
| @sentry/core/server |
44.53 kB |
- |
- |
| @sentry/core/browser |
13.99 kB |
- |
- |
| @sentry/node |
149.48 kB |
-0.01% |
-3 B 🔽 |
| @sentry/node/import (ESM hook with diagnostics-channel injection) |
83.3 kB |
- |
- |
| @sentry/node - without tracing |
88.38 kB |
-0.01% |
-7 B 🔽 |
| @sentry/node - without channel injection |
138.45 kB |
-0.01% |
-1 B 🔽 |
| @sentry/aws-serverless |
97.29 kB |
-0.01% |
-4 B 🔽 |
| @sentry/cloudflare (withSentry) - minified |
204.35 kB |
- |
- |
| @sentry/cloudflare (withSentry) |
474.32 kB |
- |
- |
| @sentry/nextjs/cloudflare (withSentry) - minified |
229.66 kB |
- |
- |
View base workflow run
|
sentry-junior[bot] reacted with eyes emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Optional E2E tests
Some optional checks were not successful. They do not block the merge. 10 not successful, 50 successful. See the run.
|
Check |
Status |
|
| ❌ |
CI: Optional E2E Tests / E2E nextjs-16-cacheComponents (cloudflare) Test (optional) |
Failing after 10m |
Details |
| ❌ |
CI: Optional E2E Tests / E2E node-eve (orchestrion) Test (optional) |
Failing after 2m |
Details |
| ❌ |
CI: Optional E2E Tests / E2E node-eve (latest) Test (optional) |
Failing after 2m |
Details |
| ❌ |
CI: Optional E2E Tests / E2E node-eve Test (optional) |
Failing after 2m |
Details |
| ❌ |
CI: Optional E2E Tests / E2E nuxt-5 (tunnel-dev) Test (optional) |
Failing after 21s |
Details |
| ❌ |
CI: Optional E2E Tests / E2E nuxt-5 Test (optional) |
Failing after 29s |
Details |
| ❌ |
CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) |
Failing after 31s |
Details |
| ❌ |
CI: Optional E2E Tests / E2E nuxt-5-cloudflare Test (optional) |
Failing after 21s |
Details |
| ❌ |
CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) |
Failing after 20s |
Details |
| ❌ |
CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) |
Failing after 34s |
Details |
Successful checks
|
Check |
Status |
|
| ✅ |
CI: Optional E2E Tests / E2E astro-7-static Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E cloudflare-think (ai v6) Test (optional) |
Successful in 57s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E cloudflare-mastra Test (optional) |
Successful in 43s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-openai-decisions (latest) Test (optional) |
Successful in 26s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E cloudflare-pi-durable (latest) Test (optional) |
Successful in 41s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E gen-ai-libraries Test (optional) |
Successful in 46s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E gen-ai-libraries (cloudflare) Test (optional) |
Successful in 38s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E astro-7 Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E cloudflare-workers-send-to-sentry Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E cloudflare-flue-send-to-sentry Test (optional) |
Successful in 3m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E cloudflare-agent Test (optional) |
Successful in 37s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nestjs-12 (deno) Test (optional) |
Successful in 53s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nestjs-12 (latest) Test (optional) |
Successful in 53s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nextjs-16 (deno) Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nestjs-12 (cloudflare) Test (optional) |
Successful in 51s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) |
Successful in 56s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E cloudflare-pi-durable Test (optional) |
Successful in 50s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E deno (latest) Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-pi-durable Test (optional) |
Successful in 35s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-express-send-to-sentry Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E debug-id-sourcemaps Test (optional) |
Successful in 33s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E cloudflare-think Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E gen-ai-libraries (latest) Test (optional) |
Successful in 56s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-express-mcp-v2 Test (optional) |
Successful in 34s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-express-mcp-v1 Test (optional) |
Successful in 26s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-pi-durable (latest) Test (optional) |
Successful in 43s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nestjs-12 (bun) Test (optional) |
Successful in 52s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) |
Successful in 3m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-flue (latest) Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-mastra (latest) Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-fastify-6 Test (optional) |
Successful in 31s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-mastra Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-openai-decisions Test (optional) |
Successful in 25s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-fastify-6 (tracer provider) Test (optional) |
Successful in 33s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-express-send-to-sentry-static Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E node-flue Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) |
Successful in 32s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E solidstart-2 Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E react-send-to-sentry Test (optional) |
Successful in 2m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) |
Successful in 37s |
Details |
| ✅ |
CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) |
Successful in 1m |
Details |
| ✅ |
CI: Optional E2E Tests / E2E vue-3 (no Options API) Test (optional) |
Successful in 1m |
Details |
|
sentry-junior[bot] reacted with eyes emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
into feat/replace-nodemon-with-tsx-watch
# Conflicts:
# package.json
# pnpm-lock.yaml
It ran a playwright binary at a path that no longer exists, and no package
under packages/ has playwright tests anymore.
Co-Authored-By: Francesco Gringl-Novy <[email protected]>
This branch has not been deployed
No deployments
Reviewers
chargome
Awaiting requested review from chargome
s1gr1d
Awaiting requested review from s1gr1d
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|