GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Set daemon attribute instead of using setDaemon method that was deprecated in Python 3.10 by tirkarthi · Pull Request #1093 · getsentry/sentry-python

Conversation

@tirkarthi

@tirkarthi tirkarthi commented Apr 17, 2021

Copy link
Copy Markdown
Contributor

Fixes #1092

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tirkarthi @ahmedetefy
Set daemon attribute instead of using setDaemon method that was depre…
260d56c 
…cated in Python 3.10
@ahmedetefy
ahmedetefy force-pushed the fix-threading branch from aab17cb to 260d56c Compare June 14, 2021 07:14
@ahmedetefy

ahmedetefy commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Thanks for the PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahmedetefy
ahmedetefy merged commit b065890 into getsentry:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

threading.setDaemon has been deprecated in favor of setting daemon attribute directly in Python 3.10

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tirkarthi @ahmedetefy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.