GeezerVison

To confirm, the op, origin here is referring to the values that would normally live in the sentry.op and sentry.origin span attributes?

Yupp, I originally I had 2 separate hooks for sentry.op and sentry.origin; not sure why I changed it to a single one. I changed it back to 2 separate ones since it’s more clear.

I saw the comment about this in the pull request summary and was wondering - do we know why this happens?

Not sure if you've learned the background on this design choice as you've been making changes in this integration. 🤔

I wanted to first discuss with someone on whether this was a good approach or not, but didn’t get the chance. The idea was that a specific service module (e.g. _services/s3.py) would only be loaded at the time it was needed (first client call that needs it).

This is probably not needed when there are only a few number of extensions (final target is ~9), but might improve performance if there are more and have a number of dependencies/are large? I’m really not sure about this, the gains would probably negligible compared to the variance in network calls…

I guess it’s easier to just start with a static map like this, what do you think?

from sentry_sdk.integrations.boto3._services.s3 import _S3Extension

_SERVICE_EXTENSIONS = {
	“s3”: _S3Extension
}

def _resolve_service(service_name: str):
	return _SERVICE_EXTENSIONS.get(service_name)

Yeah, I think the static map approach would be easier to start with, and if we see that we're starting to impact performance we can revisit this.

As an aside, I think we may take a harder look at our lazy-loading approach once Python 3.15 drops with the lazy keyword support

I'm not sure I follow why we want this to happen. Could you provide some context on why we'd rather this than the other way around (service-specific overrides generic)?

Not sure why I did this (maybe for future AWS services there might be overlap between attributes, but I doubt it). Even if there is overlap, I think you would want service-precedence or just decide for that specific attribute which one should be kept.

I put it back that generic attributes are set first, service-specific ones are set later.