GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — ref(boto3): Split integration into internal modules by pabloDeputter · Pull Request #7537 · getsentry/sentry-python

Conversation

pabloDeputter commented Sep 18, 2026

Copy link

Copy Markdown

Contributor

Description

Move Boto3Integration from single module into package with smaller internal modules.

botocore client patching is moved into _client.py.
request instrumentation and event handlers into _instrumentation.py.
existing public import is kept unchanged: from sentry_sdk.integrations.boto3 import Boto3Integration.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pabloDeputter added this pull request to stack #7539

September 18, 2026 14:23

github-actions Bot commented Sep 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Codecov Results 📊

✅ 132233 passed | ⏭️ 7214 skipped | Total: 139447 | Pass Rate: 94.83% | Execution Time: 440m 53s

📊 Comparison with Base Branch

Metric	Change
Total Tests	📈 +2863
Passed Tests	📈 +2906
Failed Tests	📉 -60
Skipped Tests	📈 +17

➖ Removed Tests (60)

View removed tests

test_input_attributes_nonstreaming_chat[False-True-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-True-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-True-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-False-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-False-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-False-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-False-False]
- File: tests.integrations.mistral.test_mistral
test_cache_spans_templatetag[True]
- File: tests.integrations.django.test_cache_module

All tests are passing successfully.

✅ Patch coverage is 90.24%. Project has 2551 uncovered lines.
❌ Project coverage is 90.29%. Comparing base (9268111) to head (b21b888).

Files with missing lines (2)

File	Patch %	Lines
sentry_sdk/integrations/boto3/init.py	87.50%	⚠️ 2 Missing
sentry_sdk/integrations/boto3/_client.py	89.47%	⚠️ 2 Missing

Coverage diff

@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.30%    90.29%    -0.01%
==========================================
  Files          195       198        +3
  Lines        26261     26279       +18
  Branches      9798      9798         —
==========================================
+ Hits         23714     23728       +14
- Misses        2547      2551        +4
- Partials      1485      1485         —

Generated by Codecov Action

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pabloDeputter removed this pull request from stack #7539

September 18, 2026 15:08

pabloDeputter added this pull request to stack #7541

September 18, 2026 15:08

pabloDeputter marked this pull request as ready for review

September 18, 2026 15:12

pabloDeputter requested a review from a team as a code owner

September 18, 2026 15:12

ericapisani requested changes

Sep 18, 2026

View reviewed changes

Comment thread

sentry_sdk/integrations/boto3/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot reviewed

Sep 21, 2026

View reviewed changes

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

sentry_sdk/integrations/boto3/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

ericapisani approved these changes

Sep 21, 2026

View reviewed changes

ericapisani left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the earlier changes. There's one more change that we can try and make to avoid the need for dynamic imports altogether, have left a comment within one of the methods explaining.

Otherwise, this LGTM, approving in order to not block once that's been addressed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pabloDeputter reacted with heart emoji

All reactions

❤️ 1 reaction

Comment thread

sentry_sdk/integrations/boto3/_instrumentation.py Outdated

		def _sentry_before_sign(
		request: "AWSRequest", signature_version: "Any", **kwargs: "Any"
		) -> None:
		from sentry_sdk.integrations.boto3 import Boto3Integration

ericapisani Sep 21, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fun thing that you can do to try and get around the need for this dynamic import - you can provide the string rather than the class to client.get_integration.

So I think lines 117 and 118 below would look like this:

if client.get_integration("Boto3Integration") is None:
        return

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pabloDeputter reacted with thumbs up emoji

All reactions

👍 1 reaction

pabloDeputter Sep 21, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay good to know, I didn't knew this was possible. Then we'll probably use client.get_integration("boto3") instead, right? Since we use boto3 as identifier for the integration.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericapisani reacted with thumbs up emoji

All reactions

👍 1 reaction

pabloDeputter Sep 21, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this probably in a later PR, cause I don't want to do merge hell once again 😭

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ericapisani Sep 24, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, totally understandable 👍🏻

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pabloDeputter force-pushed the pablo/refactor-boto3-integration branch 4 times, most recently from 5bbe368 to 591151d Compare

September 22, 2026 14:53

pabloDeputter removed this pull request from stack #7541

September 22, 2026 14:57

pabloDeputter added this pull request to stack #7618

September 22, 2026 14:57

pabloDeputter force-pushed the pablo/refactor-boto3-integration branch from 591151d to 81fd35f Compare

September 29, 2026 08:34

cursor Bot reviewed

Sep 29, 2026

View reviewed changes

cursor Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 81fd35f. Configure here.}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

sentry_sdk/integrations/boto3/_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

pabloDeputter force-pushed the pablo/refactor-boto3-integration branch from 8bf4d1c to a45c039 Compare

September 30, 2026 12:04

pabloDeputter removed this pull request from stack #7618

September 30, 2026 12:05

pabloDeputter added this pull request to stack #7792

September 30, 2026 12:05

pabloDeputter force-pushed the pablo/refactor-boto3-integration branch from c9e19dc to d4858fe Compare

September 30, 2026 13:31

pabloDeputter added 5 commits

September 30, 2026 16:04


          ref(boto3): split integration into internal modules

4d1d3f5


          ref(boto3): Move consts to

0c23830


          fix(boto3): Move imports

b45f76c


          ref(boto3): Remove dupliocate _check_minimum_version()

ab843bc


          ref(boto3): Update integration checks to use IDENTIFIER constant

b21b888

pabloDeputter force-pushed the pablo/refactor-boto3-integration branch from d4858fe to b21b888 Compare

September 30, 2026 14:05

pabloDeputter merged commit 505c6db into master

Sep 30, 2026

314 of 316 checks passed

Uh oh!

There was an error while loading. Please reload this page.

pabloDeputter deleted the pablo/refactor-boto3-integration branch

September 30, 2026 15:50

sentry-release-bot Bot mentioned this pull request

Oct 12, 2026

publish: getsentry/[email protected] getsentry/publish#9830

Closed

6 tasks done

Reviewers

ericapisani

ericapisani approved these changes

cursor[bot]

cursor[bot] left review comments

alexander-alderman-webb

alexander-alderman-webb left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

pabloDeputter commented Sep 18, 2026

Description

Uh oh!

github-actions Bot commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

📊 Comparison with Base Branch

➖ Removed Tests (60)

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ericapisani left a comment

Choose a reason for hiding this comment

Uh oh!

ericapisani Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

pabloDeputter Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

pabloDeputter Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

ericapisani Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Sep 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.