GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ref(data-collection): Promote `data_collection` from `_experiments` o top-level by ericapisani · Pull Request #7560 · getsentry/sentry-python

Conversation

@ericapisani

@ericapisani ericapisani commented Sep 21, 2026

Copy link
Copy Markdown
Member

Move data_collection out of _experiments into a documented top-level sentry_sdk.init() option. Update has_data_collection_enabled to check provided_by_user on the resolved dict instead of key presence under _experiments, and update all integration tests to pass data_collection at the top level.

Fixes PY-2796
Fixes #7557

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericapisani
ref(data-collection): Promote data_collection from _experiments t…
b30e774 
…o top-level

Move `data_collection` out of `_experiments` into a documented top-level
`sentry_sdk.init()` option. Update `has_data_collection_enabled` to check
`provided_by_user` on the resolved dict instead of key presence under
`_experiments`, and update all integration tests to pass `data_collection`
at the top level.

Fixes PY-2796
Fixes #7557
@linear-code

linear-code Bot commented Sep 21, 2026

Copy link
Copy Markdown

PY-2796
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericapisani added 3 commits September 21, 2026 10:53
@ericapisani
.
3debd60
@ericapisani
Merge branch 'master' into py-2796-move-data-collection-to-top-level
bd97f02
@ericapisani
update mistral tests
9286fa5
@github-actions

github-actions Bot commented Sep 21, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 129753 passed | ⏭️ 7148 skipped | Total: 136901 | Pass Rate: 94.78% | Execution Time: 431m 52s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +375
Passed Tests 📈 +375
Failed Tests —
Skipped Tests —

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2543 uncovered lines.

Generated by Codecov Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericapisani
ericapisani marked this pull request as ready for review September 21, 2026 15:29
@ericapisani
ericapisani requested a review from a team as a code owner September 21, 2026 15:29
sentrivana
sentrivana approved these changes Sep 21, 2026
View reviewed changes

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to not block, but please see comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread sentry_sdk/consts.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread sentry_sdk/data_collection.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread sentry_sdk/utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
sentrivana added 2 commits September 22, 2026 10:28
@sentrivana
keep in experiments
b5949fc
@sentrivana
fix
81f9294
@sentrivana
sentrivana enabled auto-merge (squash) September 22, 2026 08:36
alexander-alderman-webb
alexander-alderman-webb approved these changes Sep 22, 2026
View reviewed changes
@sentrivana
Merge branch 'master' into py-2796-move-data-collection-to-top-level
e01bb6f
@sentrivana
sentrivana merged commit d99edef into master Sep 22, 2026
161 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
sentrivana deleted the py-2796-move-data-collection-to-top-level branch September 22, 2026 09:04
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Sep 22, 2026
publish: getsentry/[email protected] getsentry/publish#9604
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes
@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move data_collection setting to top-level of config

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericapisani @sentrivana @alexander-alderman-webb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.