GeezerVison is showing github.com — test(otlp): Adjust to `OTLPSpanExporter._headers` removal by alexander-alderman-webb · Pull Request #7722 · getsentry/sentry-python
Conversation
Description
As we pulled in version 1.45.0 of the unpinned opentelemetry package, we see failures like
tests/integrations/otlp/test_otlp.py:297: in test_collector_url_none_falls_back_to_dsn
assert "X-Sentry-Auth" in exporter._headers
^^^^^^^^^^^^^^^^^
E AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'
The responsible commit in opentelemetry is open-telemetry/opentelemetry-python@89cc68b
Issues
Reminders
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Results 📊
✅ 129902 passed | ⏭️ 7152 skipped | Total: 137054 | Pass Rate: 94.78% | Execution Time: 437m 22s
📊 Comparison with Base Branch
| Metric |
Change |
| Total Tests |
— |
| Passed Tests |
— |
| Failed Tests |
— |
| Skipped Tests |
— |
✨ No test changes detected
All tests are passing successfully.
✅ Patch coverage is 100.00%. Project has 2544 uncovered lines.
✅ Project coverage is 90.23%. Comparing base (b499d89) to head (f1cc753).
Coverage diff
@@ Coverage Diff @@
## master #PR +/-##
==========================================
+ Coverage 90.21% 90.23% +0.02%
==========================================
Files 194 194 —
Lines 26030 26030 —
Branches 9678 9678 —
==========================================
+ Hits 23480 23486 +6
- Misses 2550 2544 -6
- Partials 1454 1455 +1
Generated by Codecov Action
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.