GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(aiohttp): Add `sentry.is_localhost` for inbound filters by sentrivana · Pull Request #7785 · getsentry/sentry-python

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

Mirrors https://github.com/getsentry/relay/blob/master/relay-filter/src/localhost.rs

Part 4 of #7727

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sentrivana
sentrivana added this pull request to stack #7782 September 30, 2026 09:00
@sentrivana sentrivana changed the title Ivana/is localhost 4 aiohttp feat(aiohtttp): Add sentry.is_localhost for inbound filters Sep 30, 2026
@sentrivana
sentrivana force-pushed the ivana/is-localhost-4-aiohttp branch from 30a560a to ddf568b Compare September 30, 2026 09:03
sentry-warden[bot]
sentry-warden Bot reviewed Sep 30, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/aiohttp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
sentrivana force-pushed the ivana/is-localhost-4-aiohttp branch from ddf568b to beb7225 Compare September 30, 2026 09:12
sentry-warden[bot]
sentry-warden Bot reviewed Sep 30, 2026
View reviewed changes
Comment thread tests/integrations/aiohttp/test_aiohttp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Sep 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 130388 passed | ⏭️ 7185 skipped | Total: 137573 | Pass Rate: 94.78% | Execution Time: 443m 41s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -133
Passed Tests 📉 -196
Failed Tests —
Skipped Tests 📈 +63

All tests are passing successfully.

✅ Patch coverage is 87.50%. Project has 2548 uncovered lines.
✅ Project coverage is 90.29%. Comparing base (e1f5e70) to head (6b8f393).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/aiohttp.py 87.50% ⚠️ 1 Missing and 1 partials
Coverage diff 
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.26%    90.29%    +0.03%
==========================================
  Files          195       195         —
  Lines        26226     26234        +8
  Branches      9776      9780        +4
==========================================
+ Hits         23672     23686       +14
- Misses        2554      2548        -6
- Partials      1484      1485        +1

Generated by Codecov Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
sentrivana force-pushed the ivana/is-localhost-4-aiohttp branch from beb7225 to 218a04e Compare September 30, 2026 09:30
@sentrivana
sentrivana force-pushed the ivana/is-localhost-4-aiohttp branch 5 times, most recently from 2ee34e7 to 8b96fa7 Compare September 30, 2026 09:46
@sentrivana
sentrivana force-pushed the ivana/is-localhost-4-aiohttp branch from 8b96fa7 to 2d35c3e Compare September 30, 2026 09:47
@sentrivana
sentrivana marked this pull request as ready for review September 30, 2026 09:55
@sentrivana
sentrivana requested a review from a team as a code owner September 30, 2026 09:55
Base automatically changed from ivana/is-localhost-3-sanic to master September 30, 2026 10:09
sentrivana added 3 commits September 30, 2026 12:09
@sentrivana
feat(wsgi): Add sentry.is_localhost for inbound filters
fa7427c
@sentrivana
feat(asgi): Add sentry.is_localhost for inbound filters
e53383f
@sentrivana
feat(aiohttp): Add sentry.is_localhost for inbound filters
6b8f393
@sentrivana
sentrivana force-pushed the ivana/is-localhost-4-aiohttp branch from 2d35c3e to 6b8f393 Compare September 30, 2026 10:09
alexander-alderman-webb
alexander-alderman-webb approved these changes Sep 30, 2026
View reviewed changes
@sentrivana sentrivana changed the title feat(aiohtttp): Add sentry.is_localhost for inbound filters feat(aiohttp): Add sentry.is_localhost for inbound filters Sep 30, 2026
@sentrivana
sentrivana merged commit 0e9f701 into master Sep 30, 2026
314 of 316 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
sentrivana deleted the ivana/is-localhost-4-aiohttp branch September 30, 2026 11:08
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Oct 12, 2026
publish: getsentry/[email protected] getsentry/publish#9830
Closed
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry-warden sentry-warden[bot] sentry-warden[bot] left review comments
@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sentrivana @alexander-alderman-webb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.