GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test(starlette): Expect parametrized route in `starlette>=1.7` by alexander-alderman-webb · Pull Request #7789 · getsentry/sentry-python

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Description

The ASGI integration sets the parametrized path as the transaction name from the ASGI scope "route" property.
Starlette started setting the property in new versions.

Issues

Closes #7778

Reminders

  • Please add tests to validate your changes, and lint your code using uv run ruff.
  • Add GH Issue ID & Linear ID (if applicable)
  • PR title should use conventional commit style (feat:, fix:, ref:, meta:)
  • For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alexander-alderman-webb
test(starlette): Expect parametrized route in starlette>=1.7
21da8da
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 30, 2026 10:49
@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 130355 passed | ⏭️ 7185 skipped | Total: 137540 | Pass Rate: 94.78% | Execution Time: 454m 31s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +78
Passed Tests 📈 +62
Failed Tests —
Skipped Tests 📈 +16

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2547 uncovered lines.
✅ Project coverage is 90.29%. Comparing base (e1f5e70) to head (21da8da).

Coverage diff 
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.26%    90.29%    +0.03%
==========================================
  Files          195       195         —
  Lines        26226     26226         —
  Branches      9776      9776         —
==========================================
+ Hits         23672     23679        +7
- Misses        2554      2547        -7
- Partials      1484      1484         —

Generated by Codecov Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alexander-alderman-webb alexander-alderman-webb changed the title test(starlette): Expect parametrized route in starlette>=1.7 test(starlette): Expect parametrized route in starlette>=1.7 Sep 30, 2026
sentrivana
sentrivana approved these changes Sep 30, 2026
View reviewed changes
@alexander-alderman-webb
alexander-alderman-webb merged commit 6c2ec6e into master Sep 30, 2026
166 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/starlette/route branch September 30, 2026 12:12
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Oct 12, 2026
publish: getsentry/[email protected] getsentry/publish#9830
Closed
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Starlette CI failures

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@alexander-alderman-webb @sentrivana
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.