GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(asgi): Set `user_agent.original` for inbound filters by sentrivana · Pull Request #7794 · getsentry/sentry-python

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Part 2 of https://linear.app/getsentry/issue/PY-2898/implement-user-agentoriginal

Also deduped some ASGI app setup code in the tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sentrivana
sentrivana force-pushed the ivana/user-agent-original-2 branch from 457133c to 33e3b86 Compare September 30, 2026 13:01
sentrivana added 2 commits September 30, 2026 15:02
@sentrivana
feat(asgi): Set user_agent.original for inbound filters
2a8851e
@sentrivana
feat(asgi): Add user_agent.original attr for inbound filters
4695dc0
@sentrivana
sentrivana force-pushed the ivana/user-agent-original-2 branch from 33e3b86 to 4695dc0 Compare September 30, 2026 13:02
@sentrivana
remove unused lifespan
8cfe04e
@sentrivana sentrivana changed the title Ivana/user agent original 2 feat(asgi): Set user_agent.original for inbound filters Sep 30, 2026
@sentrivana
?
7ccd44b
@sentrivana
sentrivana marked this pull request as ready for review September 30, 2026 13:12
@sentrivana
sentrivana requested a review from a team as a code owner September 30, 2026 13:12
@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 131396 passed | ⏭️ 7185 skipped | Total: 138581 | Pass Rate: 94.82% | Execution Time: 443m 51s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +3804
Passed Tests 📈 +3807
Failed Tests 📉 -3
Skipped Tests —

➖ Removed Tests (2)

View removed tests
  • test_binary_content_encoding_mixed_content[False-False]
    • File: tests.integrations.litellm.test_litellm
  • test_cache_spans_decorator[True]
    • File: tests.integrations.django.test_cache_module

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2556 uncovered lines.

Generated by Codecov Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
alexander-alderman-webb
alexander-alderman-webb approved these changes Oct 1, 2026
View reviewed changes
@sentrivana
sentrivana merged commit 564c6c1 into master Oct 1, 2026
166 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
sentrivana deleted the ivana/user-agent-original-2 branch October 1, 2026 09:51
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Oct 12, 2026
publish: getsentry/[email protected] getsentry/publish#9830
Closed
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sentrivana @alexander-alderman-webb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.