GeezerVison is showing github.com — ci(strawberry-graphql): Bump version for type checking to 0.332.0 by alexander-alderman-webb · Pull Request #7936 · getsentry/sentry-python
Conversation
Description
graphql-python/graphql-core@206de32 made GraphQLResolveInfo generic.
graphql-python/graphql-core@9ad67e2 made OperationDefinitionNode.variable_definitions possibly None.
Resolve
sentry_sdk/integrations/gql.py:66: error: Incompatible types in assignment (expression has type "tuple[VariableDefinitionNode, ...] | None", target has type "str | tuple[VariableDefinitionNode, ...]") [assignment]
sentry_sdk/integrations/gql.py:68: error: Incompatible types in assignment (expression has type "tuple[VariableDefinitionNode, ...] | None", target has type "str | tuple[VariableDefinitionNode, ...]") [assignment]
sentry_sdk/integrations/strawberry.py:325: error: Missing type arguments for generic type "GraphQLResolveInfo" [type-arg]
sentry_sdk/integrations/strawberry.py:326: error: Missing type arguments for generic type "GraphQLResolveInfo" [type-arg]
sentry_sdk/integrations/strawberry.py:332: error: Missing type arguments for generic type "GraphQLResolveInfo" [type-arg]
sentry_sdk/integrations/strawberry.py:334: error: Missing type arguments for generic type "GraphQLResolveInfo" [type-arg]
sentry_sdk/integrations/strawberry.py:347: error: Missing type arguments for generic type "GraphQLResolveInfo" [type-arg]
sentry_sdk/integrations/strawberry.py:349: error: Missing type arguments for generic type "GraphQLResolveInfo" [type-arg]
sentry_sdk/integrations/strawberry.py:391: error: Missing type arguments for generic type "GraphQLResolveInfo" [type-arg]
Issues
Reminders
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Results 📊
✅ 133451 passed | ⏭️ 7276 skipped | Total: 140727 | Pass Rate: 94.83% | Execution Time: 439m 19s
📊 Comparison with Base Branch
| Metric |
Change |
| Total Tests |
— |
| Passed Tests |
— |
| Failed Tests |
— |
| Skipped Tests |
— |
✨ No test changes detected
All tests are passing successfully.
✅ Patch coverage is 100.00%. Project has 2593 uncovered lines.
❌ Project coverage is 90.26%. Comparing base (7cb8094) to head (010ff78).
Coverage diff
@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.29% 90.26% -0.03%
==========================================
Files 202 202 —
Lines 26625 26625 —
Branches 9926 9926 —
==========================================
+ Hits 24039 24032 -7
- Misses 2586 2593 +7
- Partials 1515 1515 —
Generated by Codecov Action
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.