GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(types): Export DataCollectionUserOptions from sentry_sdk.types by sentrivana · Pull Request #7957 · getsentry/sentry-python

Conversation

@sentrivana

@sentrivana sentrivana commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Make DataCollectionUserOptions importable from sentry_sdk.types without a TYPE_CHECKING guard, following the same pattern as the other public types (real type for type checkers, Any at runtime).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sentrivana
feat(types): Export DataCollectionUserOptions from sentry_sdk.types
9139de3 
Make DataCollectionUserOptions importable from sentry_sdk.types at
runtime, without requiring a TYPE_CHECKING guard, consistent with the
other public types.
@sentrivana
sentrivana marked this pull request as ready for review October 12, 2026 12:13
@sentrivana
sentrivana requested a review from a team as a code owner October 12, 2026 12:13
alexander-alderman-webb
alexander-alderman-webb approved these changes Oct 12, 2026
View reviewed changes
@sentrivana
sentrivana enabled auto-merge (squash) October 12, 2026 12:15
@github-actions

github-actions Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 133451 passed | ⏭️ 7276 skipped | Total: 140727 | Pass Rate: 94.83% | Execution Time: 444m 49s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +3059
Passed Tests 📈 +3061
Failed Tests 📉 -2
Skipped Tests —

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_mixed_content[False-False]
    • File: tests.integrations.litellm.test_litellm

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2585 uncovered lines.

Generated by Codecov Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
sentrivana merged commit 5780399 into master Oct 12, 2026
166 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
sentrivana deleted the ivana/export-data-collection-user-options branch October 12, 2026 12:24
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Oct 12, 2026
publish: getsentry/[email protected] getsentry/publish#9830
Closed
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sentrivana @alexander-alderman-webb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.