GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(logs): resolve Batcher deadlock from lock-order inversion by intertermux-code · Pull Request #7965 · getsentry/sentry-python

Conversation

@intertermux-code

@intertermux-code intertermux-code commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

The log Batcher deadlocked due to a lock-order inversion between Batcher._lock and the SentryLogsHandler lock when a GC finalizer logged. Repro deadlocked 7/7 times in ~5s.

Fix: swap the buffer under the lock, serialize outside it (~21 lines in _batcher.py). After the fix: 62453 logs/30s with no deadlock. pytest 59 passed; new regression test fails without the fix and passes with it.

Fixes #7775.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@intertermux-code
Fix deadlock from lock-order inversion between log Batcher and Sentry…
a67a4ed 
…LogsHandler

Fixes getsentry#7775.
@intertermux-code
intertermux-code requested a review from a team as a code owner October 12, 2026 14:27
@alexander-alderman-webb

alexander-alderman-webb commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

There's already a PR open for this: #7776
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alexander-alderman-webb alexander-alderman-webb closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deadlock between log batcher lock and logging handler lock when GC runs a finalizer that logs

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@intertermux-code @alexander-alderman-webb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.