GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(cohere): Stop swallowing exceptions during stream iteration by intertermux-code · Pull Request #8017 · getsentry/sentry-python

Conversation

@intertermux-code

@intertermux-code intertermux-code commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #7889.

Split out of #7946 per review — this one covers the cohere integration only. Mid-stream provider exceptions raised by the chat iterator were swallowed by the outer capture_internal_exceptions(); they now bubble out to the caller while the span is still closed out.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@intertermux-code
fix(cohere): stop swallowing stream iteration errors
a285b7f 
Split out of getsentry#7946 per review. Mid-stream provider exceptions raised
by the chat iterator were swallowed by the outer
capture_internal_exceptions(); they now bubble out to the caller
while the span is still closed out.
@intertermux-code
intertermux-code requested a review from a team as a code owner October 13, 2026 11:26
cursor[bot]
cursor Bot reviewed Oct 13, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a285b7f. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread sentry_sdk/integrations/cohere.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
alexander-alderman-webb
alexander-alderman-webb requested changes Oct 13, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/cohere.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@alexander-alderman-webb alexander-alderman-webb mentioned this pull request Oct 13, 2026
fix(huggingface_hub): Stop swallowing exceptions during stream iteration #8018
Merged
alexander-alderman-webb
alexander-alderman-webb approved these changes Oct 13, 2026
View reviewed changes
@alexander-alderman-webb alexander-alderman-webb changed the title fix(cohere): stop swallowing stream iteration errors fix(cohere): Stop swallowing exceptions during stream iteration Oct 13, 2026
@alexander-alderman-webb
alexander-alderman-webb merged commit cc90b4d into getsentry:master Oct 13, 2026
161 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@intertermux-code
intertermux-code deleted the fix/7889-cohere-stream-iteration-errors branch October 16, 2026 18:46
This was referenced Oct 21, 2026
publish: getsentry/[email protected] getsentry/publish#9946
Closed
publish: getsentry/[email protected] getsentry/publish#9970
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hugging Face Hub and Cohere integrations swallow errors raised while iterating a stream

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@intertermux-code @alexander-alderman-webb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.