GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(asyncio): fork task scope when task is created by bhabishnu · Pull Request #8022 · getsentry/sentry-python

Conversation

@bhabishnu

@bhabishnu bhabishnu commented Oct 13, 2026

Copy link
Copy Markdown

Description

AsyncioIntegration currently forks the current scope when a task first runs. If another span becomes current between create_task() and the task's first execution, the task span can end up parented to that unrelated span.

This changes the integration to fork the current scope when the task is created instead. The isolation scope keeps its existing behavior.

The explicit context= path is handled separately so the current scope is taken from the supplied context.

Testing

Added regression coverage for:

  • task span parentage when another span becomes current before the task runs
  • tasks whose parent span has already ended
  • explicit and already-entered context=
  • eager task factories
  • scope isolation and cancellation behavior

Focused asyncio tests pass on Python 3.8, 3.10, 3.11, 3.12, 3.13, and 3.14.

Also checked:

  • ruff
  • formatting
  • mypy
  • compatibility with fix(asyncio): Keep an eager task factory recognizable as eager #7710

Issues

Resolves #7943

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bhabishnu
fix(asyncio): fork task scope when task is created
725105a

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AsyncioIntegration captures task scope after create_task()

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@bhabishnu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.