GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — test(litellm): Require filelock>=4.0.3 on Python 3.10/3.11 by sentry-junior[bot] · Pull Request #8026 · getsentry/sentry-python Conversation
Contributor
DescriptionThis fixes the Root cause
Fix
No retries, sleeps, skipped tests or weaker assertions. Reproduction: getsentry/repro#60 Original suite, run locally (
This is a draft until validation of the fix against both the repro and the original suite is posted here. Possible follow-up, not changed here: Issues
via Junior system actor --
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsfilelock 3.30.0-4.0.2 registers a Python audit hook on import. On CPython < 3.12, sys.settrace() is guarded by a process-wide reentrancy flag that stays set while audit hooks run (python/cpython#98257). With coverage installing a tracer for every thread, a freshly started ThreadPoolExecutor worker can die in Thread._bootstrap with "Cannot install a trace function while another trace function is being installed". LiteLLM finishes the gen_ai.chat span in a thread pool success callback, so the span is lost and the test sees zero chat spans. filelock 4.0.3 skips the audit hook on affected interpreters. Pin it for the py3.10/py3.11 litellm envs and regenerate tox.ini for litellm. Refs #7014
dingsdax
marked this pull request as ready for review
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
sentrivana
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
This was referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. ResolveRuntimeError: Cannot install a trace function while another trace function is being installed
Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |