GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(wsgi): Redact CF-Connecting-IP, True-Client-IP, Forwarded, and X-Client-IP by default by ryder777777 · Pull Request #8108 · getsentry/sentry-python

Conversation

@ryder777777

@ryder777777 ryder777777 commented Oct 22, 2026

Copy link
Copy Markdown

Description

Under the default configuration (send_default_pii=False and no explicit data_collection), _filter_headers in sentry_sdk/integrations/_wsgi_common.py only redacted X-Forwarded-For and X-Real-IP among proxy/CDN client IP headers, leaving CF-Connecting-IP, True-Client-IP, Forwarded, and X-Client-IP unredacted on events, transactions, and spans.

This adds HTTP_CF_CONNECTING_IP, HTTP_TRUE_CLIENT_IP, HTTP_FORWARDED, and HTTP_X_CLIENT_IP to SENSITIVE_ENV_KEYS (and removes the duplicate HTTP_X_FORWARDED_FOR entry) so SENSITIVE_HEADERS blanks all six client IP headers by default when PII collection is disabled.

Issues

  • resolves: Default config still sends client IPs in CF-Connecting-IP, True-Client-IP, Forwarded and X-Client-IP headers #8097

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ryder777777
fix(wsgi): Redact CF-Connecting-IP, True-Client-IP, Forwarded, and X-…
f10a747 
…Client-IP by default
@ryder777777
ryder777777 requested a review from a team as a code owner October 22, 2026 13:28
@ryder777777
test(wsgi): Match title-cased WSGI header names in test_wsgi
91a837e

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default config still sends client IPs in CF-Connecting-IP, True-Client-IP, Forwarded and X-Client-IP headers

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ryder777777
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.