GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(falcon): Handle integer HTTP statuses by jap · Pull Request #8139 · getsentry/sentry-python

Conversation

@jap

@jap jap commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
  • fix(falcon): Handle integer HTTP statuses (falcon integration fails when response.status is an int #8138)
  • test(falcon): Cover integer and HTTPStatus status values

Description

Add support for integer HTTP statuses in falcon Response objects and HTTPError/HTTPStatus exceptions.

The old code raised AttributeError: 'int' object has no attribute 'startswith' in bad places.

Issues

  • resolves: falcon integration fails when response.status is an int #8138
  • resolves: PY-3048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jap
jap requested a review from a team as a code owner October 27, 2026 20:13
cursor[bot]
cursor Bot reviewed Oct 27, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4b8f9f6. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread sentry_sdk/integrations/falcon.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jap
jap force-pushed the int-status branch from 4b8f9f6 to 4d40de6 Compare October 27, 2026 20:19
sentrivana
sentrivana approved these changes Oct 28, 2026
View reviewed changes

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jap, this looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sentrivana
sentrivana enabled auto-merge (squash) October 28, 2026 08:19
@sentrivana
sentrivana disabled auto-merge October 28, 2026 08:31
jap added 2 commits October 28, 2026 09:35
@jap
fix(falcon): Handle integer HTTP statuses (getsentry#8138)
e006883 
This solves two issues:

Falcon 3 and higher allow setting Response.status to an int, and the
current code breaks on that.

Falcon 4 and higher allow setting HTTPError/HTTPStatus.status to an
int, and the current code breaks on that.
@jap
test(falcon): Cover integer and HTTPStatus status values
02362cd
@jap

jap commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

oh that's weird, I though I had ran ruff.. let me try again
sentrivana reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jap
jap force-pushed the int-status branch from 4d40de6 to 02362cd Compare October 28, 2026 08:36
sentrivana
sentrivana reviewed Oct 28, 2026
View reviewed changes

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jap, there are two blockers before we can merge this, and since the branch is not open to changes from maintainers, you'll unfortunately need to do them manually:

  1. Rebase/merge latest master once #8140 has been merged (fixes unrelated test failures)
  2. Lint the change with ruff, see https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md#development-tooling

That should make CI pass.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jap reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@sentrivana
Merge branch 'master' into int-status
475a720
@sentrivana
sentrivana merged commit ed74ba7 into getsentry:master Oct 28, 2026
165 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@jap
jap deleted the int-status branch October 28, 2026 10:07
This was referenced Nov 4, 2026
publish: getsentry/[email protected] getsentry/publish#10182
Closed
publish: getsentry/[email protected] getsentry/publish#10240
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes
@cursor cursor[bot] cursor[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

falcon integration fails when response.status is an int

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jap @sentrivana
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.