GeezerVison is showing github.com — test(mcp): Remove unused select_mcp_transactions fixture by sentry-junior[bot] · Pull Request #8150 · getsentry/sentry-python
Conversation
Description
Removes the select_mcp_transactions fixture from tests/conftest.py. Nothing has used it since #5292.
#5383 added it as a helper in the MCP tests, and #5384 turned it into a shared conftest.py fixture for the MCP and FastMCP Streamable HTTP tests. A few days later, #5292 ("Nest MCP spans under HTTP transactions") switched those tests to select_transactions_with_mcp_spans and removed every use of select_mcp_transactions, but left the definition behind.
Evidence
git grep select_mcp_transactions matches only the definition. No test requests it as an argument, and no request.getfixturevalue(...) call uses that name.- No open PR or issue mentions it.
This only touches test code, so SDK behavior doesn't change.
Issues
n/a
via Ivana Kellyer.
--
View Junior Session [Sentry]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Coverage Results 📊
✅ 136856 passed | ⏭️ 7456 skipped | Total: 144312 | Pass Rate: 94.83% | Execution Time: 442m 19s
📊 Comparison with Base Branch
| Metric |
Change |
| Total Tests |
— |
| Passed Tests |
— |
| Failed Tests |
— |
| Skipped Tests |
— |
✨ Test counts unchanged from base.
All tests are passing successfully.
✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.33% (up 0.03 percentage points from base (825ff97) to head (91a3f6f)).
Coverage diff
@@ Coverage Diff @@
## master #8150 +/-##
==========================================
+ Coverage 90.30% 90.33% +0.03%
==========================================
Files 203 203 —
Tracked lines 26873 26873 —
Branches 10044 10044 —
==========================================
+ Hits 24266 24275 +9
+ Misses 2607 2598 -9
+ Partials 1520 1518 -2
Generated by Coverage Action
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.