GeezerVison is showing github.com — feat(typesafe): Handle inline images by alexander-alderman-webb · Pull Request #8164 · getsentry/sentry-python
Conversation
Description
Content was widened to a type that's JSON compatible or contains unserializable Image instances.
See typesafe-ai/typesafe-sdk-python@f36e685.
The change is to add a
def _json_default(value: object) -> str:
"""
Render an inline typesafe `Image` as its reference, mirroring the SDK's handling.
"""
if isinstance(value, Image):
return str(value)
return "<unserializable>"
and pass it as json.dumps(..., default=_json_default).
Issues
Closes #8167
Reminders
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Coverage Results 📊
✅ 2588 passed | ⏭️ 30 skipped | Total: 2618 | Pass Rate: 98.85% | Execution Time: 15m 15s
📊 Comparison with Base Branch
| Metric |
Change |
| Total Tests |
📉 -141000 |
| Passed Tests |
📉 -133573 |
| Failed Tests |
📉 -1 |
| Skipped Tests |
📉 -7426 |
➖ Removed Tests (1)
View removed tests
test_db_transaction_spans_disabled_no_autocommit[True]
- File:
tests.integrations.django.test_db_transactions
All tests are passing successfully.
❌ Patch coverage is 0.00% (0 of 12 changed executable lines covered; target 80%).
Project statement coverage is 32.48%.
Changed files with executable lines (1)
| File |
Patch coverage |
Changed executable lines |
| sentry_sdk/integrations/typesafe.py |
0.00% |
0/12 covered; missed: 69, 84, 85, 86, 87, 102, 106, 107, 109, 185, 291, 405 |
Generated by Coverage Action
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Handle TypeSafe images
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|