GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(typesafe): Handle inline images by alexander-alderman-webb · Pull Request #8164 · getsentry/sentry-python

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Oct 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Description

Content was widened to a type that's JSON compatible or contains unserializable Image instances.
See typesafe-ai/typesafe-sdk-python@f36e685.

The change is to add a

def _json_default(value: object) -> str:
    """
    Render an inline typesafe `Image` as its reference, mirroring the SDK's handling.
    """
    if isinstance(value, Image):
        return str(value)

    return "<unserializable>"

and pass it as json.dumps(..., default=_json_default).

Issues

Closes #8167

Reminders

  • Please add tests to validate your changes, and lint your code using uv run ruff.
  • Add GH Issue ID & Linear ID (if applicable)
  • PR title should use conventional commit style (feat:, fix:, ref:, meta:)
  • For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/typesafe/widen-type branch 4 times, most recently from 0f50489 to 3580bfd Compare October 30, 2026 10:08
sentry-warden[bot]
sentry-warden Bot reviewed Oct 30, 2026
View reviewed changes
Comment thread tests/integrations/typesafe/test_typesafe.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review October 30, 2026 10:19
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 30, 2026 10:19
@alexander-alderman-webb
feat(typesafe): Handle inline images
76e8c03
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/typesafe/widen-type branch from 3580bfd to 76e8c03 Compare October 30, 2026 10:20
@github-actions

github-actions Bot commented Oct 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 2588 passed | ⏭️ 30 skipped | Total: 2618 | Pass Rate: 98.85% | Execution Time: 15m 15s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -141000
Passed Tests 📉 -133573
Failed Tests 📉 -1
Skipped Tests 📉 -7426

➖ Removed Tests (1)

View removed tests
  • test_db_transaction_spans_disabled_no_autocommit[True]
    • File: tests.integrations.django.test_db_transactions

All tests are passing successfully.

❌ Patch coverage is 0.00% (0 of 12 changed executable lines covered; target 80%).
Project statement coverage is 32.48%.

Changed files with executable lines (1)
File Patch coverage Changed executable lines
sentry_sdk/integrations/typesafe.py 0.00% 0/12 covered; missed: 69, 84, 85, 86, 87, 102, 106, 107, 109, 185, 291, 405

Generated by Coverage Action

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sentrivana
sentrivana approved these changes Nov 3, 2026
View reviewed changes
@alexander-alderman-webb
alexander-alderman-webb merged commit ce9adf5 into master Nov 3, 2026
322 of 326 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@alexander-alderman-webb
alexander-alderman-webb deleted the webb/typesafe/widen-type branch November 3, 2026 15:27
This was referenced Nov 4, 2026
publish: getsentry/[email protected] getsentry/publish#10182
Closed
publish: getsentry/[email protected] getsentry/publish#10240
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry-warden sentry-warden[bot] sentry-warden[bot] left review comments
@sentrivana sentrivana sentrivana approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle TypeSafe images

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@alexander-alderman-webb @sentrivana
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.