GeezerVison is showing github.com — fix(wsgi): Stop overwriting `server.address` by alexander-alderman-webb · Pull Request #8171 · getsentry/sentry-python
Conversation
Description
Per OTel semantics, server.address is the attribute for WSGI's SERVER_NAME.
The attribute per OTel semantics is the network name.
In sentry-conventions we let server.address be the hostname and not just the network name.
See getsentry/sentry-conventions@dff430a.
This is needed because server.address is the value we formerly put in server_name in event-based telemetry, and that was always the hostname.
There is no other OTel attribute with the matching semantics, so I propose we stop overwriting the server.address attribute that is shared between logs, metrics and streamed spans instead of adding a new attribute to conventions.
This does mean that we drop WSGI's SERVER_NAME entirely
Issues
Closes PY-2731
Reminders
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Coverage Results 📊
✅ 136856 passed | ⏭️ 7456 skipped | Total: 144312 | Pass Rate: 94.83% | Execution Time: 465m 41s
📊 Comparison with Base Branch
| Metric |
Change |
| Total Tests |
— |
| Passed Tests |
📈 +1 |
| Failed Tests |
📉 -1 |
| Skipped Tests |
— |
➖ Removed Tests (1)
View removed tests
test_profile_stops_when_segment_ends
- File:
tests.tracing.test_span_streaming
All tests are passing successfully.
✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.31% (down 0.02 percentage points from base (7ad4e1a) to head (33439a1)).
Files with missing lines (1)
| File |
Coverage % |
Lines |
sentry_sdk/integrations/wsgi.py |
97.82% |
⚠️ 5 Missing and 7 partials |
Coverage diff
@@ Coverage Diff @@
## master #8171 +/-##
==========================================
- Coverage 90.33% 90.31% -0.02%
==========================================
Files 203 203 —
Tracked lines 26872 26869 -3
Branches 10044 10042 -2
==========================================
- Hits 24272 24265 -7
- Misses 2600 2604 +4
+ Partials 1520 1516 -4
Generated by Coverage Action
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.